by Dely Sy

[permalink] [raw]

Subject: RE: [RFC/Patch 0/12] ACPI based root bridge hot-add

On Monday, March 21, 2005 5:07 PM, Dely Sy wrote:
> On Monday, March 21, 2005 10:05 AM, Rajesh Shah wrote:
> > On Fri, Mar 18, 2005 at 09:13:32PM -0800, Greg KH wrote:
> > > - Does this break the i386 acpiphp functionality?

> > Dely Sy had tested hotplug with an earlier version of my patches
> > (with minor differences from the current series) on i386 and it
> > worked fine. She probably hasn't tested the latest one. Dely,
> > could you check that please?

> I tested an earlier version of this patch on my i386 system with
> PCI Express hot-plug slots. The i386 acpiphp functionality worked
> fine - i.e. I was able to do hot-plug of single- & multi-function
> cards.

> I'll check this new patch on my system.

Earlier I reported that Matthew's acpiphp rewrite had problem in
powering down slot on my i386 system. The following patch is
needed to get the acpiphp rewrite properly powering down the slot.
A similar patch was sent out to Matthew for comment and Rajesh
had tested the patch on Tiger4.

I just did a test of Rajesh's latest patch on 2.6.11.5 with
Wilcox's acpiphp rewrite and the following patch. Hot-plug of
PCI Express card worked fine on my i386 system

Thanks,
Dely

Signed-off-by: Dely Sy <[email protected]>

diff -urpN linux-2.6.11.5rbha/drivers/pci/hotplug/acpiphp_glue.c linux-2.6.11.5rbhatst/drivers/pci/hotplug/acpiphp_glue.c
--- linux-2.6.11.5rbha/drivers/pci/hotplug/acpiphp_glue.c 2005-03-22 00:56:04.000000000 -0800
+++ linux-2.6.11.5rbhatst/drivers/pci/hotplug/acpiphp_glue.c 2005-03-22 23:21:23.000000000 -0800
@@ -586,7 +586,7 @@ static int power_off_slot(struct acpiphp
list_for_each (l, &slot->funcs) {
func = list_entry(l, struct acpiphp_func, sibling);

- if (func->pci_dev && (func->flags & FUNC_HAS_PS3)) {
+ if (func->flags & FUNC_HAS_PS3) {
status = acpi_evaluate_object(func->handle, "_PS3", NULL, NULL);
if (ACPI_FAILURE(status)) {
warn("%s: _PS3 failed\n", __FUNCTION__);
@@ -601,7 +601,7 @@ static int power_off_slot(struct acpiphp
func = list_entry(l, struct acpiphp_func, sibling);

/* We don't want to call _EJ0 on non-existing functions. */
- if (func->pci_dev && (func->flags & FUNC_HAS_EJ0)) {
+ if (func->flags & FUNC_HAS_EJ0) {
/* _EJ0 method take one argument */
arg_list.count = 1;
arg_list.pointer = &arg;

2005-03-23 23:03:44

On Thu, 2005-03-31 at 14:03 -0800, Rajesh Shah wrote:
> Does this patch help?

YES! I can now power down the slot, see it gone from pci list, reenable
it, etc. Awesome. Thank you.

[root@intlhotp-1 ~]# lspci -s 08:00
08:00.0 Ethernet controller: Intel Corp.: Unknown device 105f (rev 03)
08:00.1 Ethernet controller: Intel Corp.: Unknown device 105f (rev 03)
[root@intlhotp-1 ~]# cd /sys/bus/pci/slots/4/
[root@intlhotp-1 4]# cat power
1
[root@intlhotp-1 4]# echo 0 > power
[root@intlhotp-1 4]# lspci -s 08:00
[root@intlhotp-1 4]# cat power
0
[root@intlhotp-1 4]# echo 1 > power
[root@intlhotp-1 4]# lspci -s 08:00
08:00.0 Ethernet controller: Intel Corp.: Unknown device 105f (rev 03)
08:00.1 Ethernet controller: Intel Corp.: Unknown device 105f (rev 03)

Attachments:

signature.asc (189.00 B)
This is a digitally signed message part