2005-03-19 13:29:27

by Domen Puncer

[permalink] [raw]
Subject: [patch 09/10] arch/i386/mm/fault.c: fix sparse warnings




Signed-off-by: Domen Puncer <[email protected]>
---


kj-domen/arch/i386/mm/fault.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff -puN arch/i386/mm/fault.c~sparse-arch_i386_mm_fault arch/i386/mm/fault.c
--- kj/arch/i386/mm/fault.c~sparse-arch_i386_mm_fault 2005-03-18 20:05:20.000000000 +0100
+++ kj-domen/arch/i386/mm/fault.c 2005-03-18 20:05:20.000000000 +0100
@@ -146,7 +146,7 @@ static int __is_prefetch(struct pt_regs

if (instr > limit)
break;
- if (__get_user(opcode, (unsigned char *) instr))
+ if (__get_user(opcode, (unsigned char __user *) instr))
break;

instr_hi = opcode & 0xf0;
@@ -173,7 +173,7 @@ static int __is_prefetch(struct pt_regs
scan_more = 0;
if (instr > limit)
break;
- if (__get_user(opcode, (unsigned char *) instr))
+ if (__get_user(opcode, (unsigned char __user *) instr))
break;
prefetch = (instr_lo == 0xF) &&
(opcode == 0x0D || opcode == 0x18);
_


2005-03-20 11:18:58

by Domen Puncer

[permalink] [raw]
Subject: Re: [patch 09/10 with proper signed-off] arch/i386/mm/fault.c: fix sparse warnings


Signed-off-by: Alexey Dobriyan <[email protected]>
Signed-off-by: Domen Puncer <[email protected]>
---


kj-domen/arch/i386/mm/fault.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff -puN arch/i386/mm/fault.c~sparse-arch_i386_mm_fault arch/i386/mm/fault.c
--- kj/arch/i386/mm/fault.c~sparse-arch_i386_mm_fault 2005-03-20 12:11:20.000000000 +0100
+++ kj-domen/arch/i386/mm/fault.c 2005-03-20 12:11:20.000000000 +0100
@@ -146,7 +146,7 @@ static int __is_prefetch(struct pt_regs

if (instr > limit)
break;
- if (__get_user(opcode, (unsigned char *) instr))
+ if (__get_user(opcode, (unsigned char __user *) instr))
break;

instr_hi = opcode & 0xf0;
@@ -173,7 +173,7 @@ static int __is_prefetch(struct pt_regs
scan_more = 0;
if (instr > limit)
break;
- if (__get_user(opcode, (unsigned char *) instr))
+ if (__get_user(opcode, (unsigned char __user *) instr))
break;
prefetch = (instr_lo == 0xF) &&
(opcode == 0x0D || opcode == 0x18);
_