2005-03-24 18:45:59

by Mikael Pettersson

Subject: [PATCH 2.6.12-rc1-mm2] x86_64: fix vsyscall.c syntax error

Compiling 2.6.12-rc1-mm2 on x86_64 with gcc-4.0 fails with:

arch/x86_64/kernel/vsyscall.c:193: error: syntax error before 'vsyscall_sysctl_change'

Fix: repair the syntax error

Signed-off-by: Mikael Pettersson <[email protected]>

--- linux-2.6.12-rc1-mm2/arch/x86_64/kernel/vsyscall.c.~1~ 2005-03-24 16:33:50.000000000 +0100
+++ linux-2.6.12-rc1-mm2/arch/x86_64/kernel/vsyscall.c 2005-03-24 19:31:40.000000000 +0100
@@ -190,7 +190,7 @@ static ctl_table kernel_table2[] = {
{ .ctl_name = 99, .procname = "vsyscall64",
.data = &sysctl_vsyscall, .maxlen = sizeof(int), .mode = 0644,
.strategy = vsyscall_sysctl_nostrat,
- .proc_handler vsyscall_sysctl_change },
+ .proc_handler = vsyscall_sysctl_change },
{ 0, }
};

2005-03-28 15:33:51

by Andi Kleen

Subject: Re: [PATCH 2.6.12-rc1-mm2] x86_64: fix vsyscall.c syntax error

Mikael Pettersson <[email protected]> writes:

Can you please cc me on all x86-64 patches?


> Compiling 2.6.12-rc1-mm2 on x86_64 with gcc-4.0 fails with:
>
> arch/x86_64/kernel/vsyscall.c:193: error: syntax error before 'vsyscall_sysctl_change'
>
> Fix: repair the syntax error

Looks ok thanks. I wish gcc folks wouldnt change the language in
each revision like this.

-Andi