2005-03-25 00:27:59

by Eric Moore

[permalink] [raw]
Subject: [PATCH 6/7] - MPT FUSION - SPLITTING SCSI HOST DRIVERS

These patches are for the mpt fusion scsi host drivers, which separate
the scsi host drivers into separate bus type kernel modules. This was
requested
by several people on the linux-scsi@ forum, so our driver can properly
support
the various transport layers; e.g. SPI, FC, and eventually SAS. In these
set of patches
the Fiber Channel controllers are moved to a new driver called mptfch.ko.
The current
Parallel SCSI controllers will remain with mptscsih.ko. Eventually we will
be adding SAS support
in the new modules that will be mptsash.ko.

Overview of attached patch

(6) mptlinux-3.03.00-6-mptscsi-c - SPI driver, having only module_init,
module_exit, and probe.

Please apply this patch against the 3.01.20 version of the mpt driver
in http://linux-scsi.bkbits.net:8080/scsi-misc-2.6

Backup of these patches can be found at this ftp:
ftp://ftp.lsil.com/HostAdapterDrivers/linux/Fusion-MPT/2.6-kernel/3.03.00/

Signed-off-by: Eric Moore <[email protected]>






Attachments:
mptlinux-3.03.00-6-mptscsi-c (13.95 kB)

2005-03-26 03:52:34

by James Bottomley

[permalink] [raw]
Subject: Re: [PATCH 6/7] - MPT FUSION - SPLITTING SCSI HOST DRIVERS

On Thu, 2005-03-24 at 16:57 -0700, Moore, Eric Dean wrote:
> +static struct device_attribute mptscsih_queue_depth_attr = {
> + .attr = {
> + .name = "queue_depth",
> + .mode = S_IWUSR,
> + },
> + .store = mpt_core_store_queue_depth,
> +};

But in the original which you're removing, this was implemented via the
change_queue_depth API.

It looks like the patches you're posting are actually an older version
of the fusion driver. Do you have the split done on a current copy?

Thanks,

James


2005-03-27 09:19:53

by Jeremy Higdon

[permalink] [raw]
Subject: Re: [PATCH 6/7] - MPT FUSION - SPLITTING SCSI HOST DRIVERS

On Fri, Mar 25, 2005 at 09:52:17PM -0600, James Bottomley wrote:
> On Thu, 2005-03-24 at 16:57 -0700, Moore, Eric Dean wrote:
> > +static struct device_attribute mptscsih_queue_depth_attr = {
> > + .attr = {
> > + .name = "queue_depth",
> > + .mode = S_IWUSR,
> > + },
> > + .store = mpt_core_store_queue_depth,
> > +};
>
> But in the original which you're removing, this was implemented via the
> change_queue_depth API.
>
> It looks like the patches you're posting are actually an older version
> of the fusion driver. Do you have the split done on a current copy?
>
> Thanks,
>
> James

James, actually this queue depth code predates your change_queue_depth
API. I don't think it was ever converted to the new API.

jeremy

2005-03-27 15:04:45

by James Bottomley

[permalink] [raw]
Subject: Re: [PATCH 6/7] - MPT FUSION - SPLITTING SCSI HOST DRIVERS

On Sun, 2005-03-27 at 01:16 -0800, Jeremy Higdon wrote:
> James, actually this queue depth code predates your change_queue_depth
> API. I don't think it was ever converted to the new API.

Erk, you're right. My todo list says I'm only waiting on 3ware patches
for all the conversions to be complete, but I think I missed auditing
fusion because it's not in the scsi directory...OK I'll do it after we
get the driver split sorted out.

James


2005-03-28 18:54:28

by Eric Moore

[permalink] [raw]
Subject: RE: [PATCH 6/7] - MPT FUSION - SPLITTING SCSI HOST DRIVERS

On Sunday, March 27, 2005 8:04 AM, James Bottomley wrote:
>
>
> On Sun, 2005-03-27 at 01:16 -0800, Jeremy Higdon wrote:
> > James, actually this queue depth code predates your
> change_queue_depth
> > API. I don't think it was ever converted to the new API.
>
> Erk, you're right. My todo list says I'm only waiting on
> 3ware patches
> for all the conversions to be complete, but I think I missed auditing
> fusion because it's not in the scsi directory...OK I'll do it after we
> get the driver split sorted out.
>
> James
>
>

I can probably look into adding this support once we get the slit drivers
accepted.

Thankyou,
Eric