2005-03-27 19:09:50

by Rolf Eike Beer

Subject: [PATCH] shrink drivers/pci/proc.c::pci_seq_start()

Hi,

this patch shrinks pci_seq_start by using for_each_pci_dev() macro instead
of explicitely using a loop and avoiding a goto.

Eike

Signed-off-by: Rolf Eike Beer <[email protected]>

--- linux-2.6.11/drivers/pci/proc.c 2005-03-21 11:41:56.000000000 +0100
+++ linux-2.6.12-rc1/drivers/pci/proc.c 2005-03-27 16:03:10.000000000 +0200
@@ -313,13 +313,10 @@ static void *pci_seq_start(struct seq_fi
struct pci_dev *dev = NULL;
loff_t n = *pos;

- dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev);
- while (n--) {
- dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev);
- if (dev == NULL)
- goto exit;
+ for_each_pci_dev(dev) {
+ if (!n--)
+ break;
}
-exit:
return dev;
}

2005-03-28 23:05:12

by Greg KH

Subject: Re: [PATCH] shrink drivers/pci/proc.c::pci_seq_start()

On Sun, Mar 27, 2005 at 03:05:43PM +0100, Rolf Eike Beer wrote:
> Hi,
>
> this patch shrinks pci_seq_start by using for_each_pci_dev() macro instead
> of explicitely using a loop and avoiding a goto.
>
> Eike
>
> Signed-off-by: Rolf Eike Beer <[email protected]>

Applied, thanks.

greg k-h