2005-04-04 18:11:00

by maximilian attems

Subject: [patch 1/3] pnpbios eliminate bad section references

one of the last buildcheck errors on i386,
thanks Randy again for double checking.

Fix pnpbios section references:
make dmi_system_id pnpbios_dmi_table __initdata

Error: ./drivers/pnp/pnpbios/core.o .data refers to 00000100 R_386_32
.init.text
Error: ./drivers/pnp/pnpbios/core.o .data refers to 0000012c R_386_32
.init.text

Signed-off-by: maximilian attems <[email protected]>


--- linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c.orig 2005-04-04 19:11:37.814477672 +0200
+++ linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c 2005-04-04 19:25:50.074402365 +0200
@@ -512,7 +512,7 @@
return 0;
}

-static struct dmi_system_id pnpbios_dmi_table[] = {
+static struct dmi_system_id pnpbios_dmi_table[] __initdata = {
{ /* PnPBIOS GPF on boot */
.callback = exploding_pnp_bios,
.ident = "Higraded P14H",

2005-04-04 19:58:03

by Randy.Dunlap

Subject: Re: [patch 1/3] pnpbios eliminate bad section references

maximilian attems wrote:
> one of the last buildcheck errors on i386,
> thanks Randy again for double checking.
>
> Fix pnpbios section references:
> make dmi_system_id pnpbios_dmi_table __initdata
>
> Error: ./drivers/pnp/pnpbios/core.o .data refers to 00000100 R_386_32
> .init.text
> Error: ./drivers/pnp/pnpbios/core.o .data refers to 0000012c R_386_32
> .init.text
>
> Signed-off-by: maximilian attems <[email protected]>
>
>
> --- linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c.orig 2005-04-04 19:11:37.814477672 +0200
> +++ linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c 2005-04-04 19:25:50.074402365 +0200
> @@ -512,7 +512,7 @@
> return 0;
> }
>
> -static struct dmi_system_id pnpbios_dmi_table[] = {
> +static struct dmi_system_id pnpbios_dmi_table[] __initdata = {
> { /* PnPBIOS GPF on boot */
> .callback = exploding_pnp_bios,
> .ident = "Higraded P14H",

Looks OK to me, but I'd prefer to leave it up to Adam.....

--
~Randy

2005-04-04 23:14:14

by Adam Belay

Subject: Re: [patch 1/3] pnpbios eliminate bad section references

On Mon, Apr 04, 2005 at 12:56:32PM -0700, Randy.Dunlap wrote:
> maximilian attems wrote:
> >one of the last buildcheck errors on i386,
> >thanks Randy again for double checking.
> >
> >Fix pnpbios section references:
> >make dmi_system_id pnpbios_dmi_table __initdata
> >
> >Error: ./drivers/pnp/pnpbios/core.o .data refers to 00000100 R_386_32
> >.init.text
> >Error: ./drivers/pnp/pnpbios/core.o .data refers to 0000012c R_386_32
> >.init.text
> >
> >Signed-off-by: maximilian attems <[email protected]>
> >
> >
> >--- linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c.orig 2005-04-04
> >19:11:37.814477672 +0200
> >+++ linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c 2005-04-04
> >19:25:50.074402365 +0200
> >@@ -512,7 +512,7 @@
> > return 0;
> > }
> >
> >-static struct dmi_system_id pnpbios_dmi_table[] = {
> >+static struct dmi_system_id pnpbios_dmi_table[] __initdata = {
> > { /* PnPBIOS GPF on boot */
> > .callback = exploding_pnp_bios,
> > .ident = "Higraded P14H",
>
> Looks OK to me, but I'd prefer to leave it up to Adam.....

Thank you for forwarding this to me. It looks good.

Cheers,
Adam