2005-04-12 17:49:01

by Blaisorblade

[permalink] [raw]
Subject: [patch 1/1] uml: add nfsd syscall when nfsd is modular


CC: <[email protected]>

This trick is useless, because sys_ni.c will handle this problem by itself,
like it does even on UML for other syscalls.
Also, it does not provide the NFSD syscall when NFSD is compiled as a module,
which is a big problem.

This should be merged currently in both 2.6.11-stable and the current tree.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[email protected]>
---

clean-linux-2.6.11-paolo/arch/um/kernel/sys_call_table.c | 8 +-------
1 files changed, 1 insertion(+), 7 deletions(-)

diff -puN arch/um/kernel/sys_call_table.c~uml-nfsd-syscall arch/um/kernel/sys_call_table.c
--- clean-linux-2.6.11/arch/um/kernel/sys_call_table.c~uml-nfsd-syscall 2005-04-10 13:50:29.000000000 +0200
+++ clean-linux-2.6.11-paolo/arch/um/kernel/sys_call_table.c 2005-04-10 13:51:19.000000000 +0200
@@ -14,12 +14,6 @@
#include "sysdep/syscalls.h"
#include "kern_util.h"

-#ifdef CONFIG_NFSD
-#define NFSSERVCTL sys_nfsservctl
-#else
-#define NFSSERVCTL sys_ni_syscall
-#endif
-
#define LAST_GENERIC_SYSCALL __NR_keyctl

#if LAST_GENERIC_SYSCALL > LAST_ARCH_SYSCALL
@@ -190,7 +184,7 @@ syscall_handler_t *sys_call_table[] = {
[ __NR_getresuid ] = (syscall_handler_t *) sys_getresuid16,
[ __NR_query_module ] = (syscall_handler_t *) sys_ni_syscall,
[ __NR_poll ] = (syscall_handler_t *) sys_poll,
- [ __NR_nfsservctl ] = (syscall_handler_t *) NFSSERVCTL,
+ [ __NR_nfsservctl ] = (syscall_handler_t *) sys_nfsservctl,
[ __NR_setresgid ] = (syscall_handler_t *) sys_setresgid16,
[ __NR_getresgid ] = (syscall_handler_t *) sys_getresgid16,
[ __NR_prctl ] = (syscall_handler_t *) sys_prctl,
_


2005-04-12 21:05:53

by Chris Wright

[permalink] [raw]
Subject: Re: [stable] [patch 1/1] uml: add nfsd syscall when nfsd is modular

* [email protected] ([email protected]) wrote:
>
> CC: <[email protected]>
>
> This trick is useless, because sys_ni.c will handle this problem by itself,
> like it does even on UML for other syscalls.
> Also, it does not provide the NFSD syscall when NFSD is compiled as a module,
> which is a big problem.

Thanks, queued to -stable.
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net