2005-04-12 18:44:33

by Andrew Morton

Subject: [patch 134/198] officially deprecate register_ioctl32_conversion

From: Christoph Hellwig <[email protected]>

These have been deprecated since ->compat_ioctl when in, thus only a short
deprecation period. There's four users left: i2o_config, s390/z90crypy,
s390/dasd and s390/zfcp and for the first two patches are about to be
submitted to get rid of it.

Signed-off-by: Andrew Morton <[email protected]>
---

25-akpm/Documentation/feature-removal-schedule.txt | 8 ++++++++
25-akpm/include/linux/ioctl32.h | 6 ++++--
2 files changed, 12 insertions(+), 2 deletions(-)

diff -puN Documentation/feature-removal-schedule.txt~officially-deprecate-register_ioctl32_conversion Documentation/feature-removal-schedule.txt
--- 25/Documentation/feature-removal-schedule.txt~officially-deprecate-register_ioctl32_conversion 2005-04-12 03:21:35.861685096 -0700
+++ 25-akpm/Documentation/feature-removal-schedule.txt 2005-04-12 03:21:35.866684336 -0700
@@ -40,3 +40,11 @@ Why: Replaced by io_remap_pfn_range() wh
addressabilty (by using a pfn) and supports sparc & sparc64
iospace as part of the pfn.
Who: Randy Dunlap <[email protected]>
+
+---------------------------
+
+What: register_ioctl32_conversion() / unregister_ioctl32_conversion()
+When: April 2005
+Why: Replaced by ->compat_ioctl in file_operations and other method
+ vecors.
+Who: Andi Kleen <[email protected]>, Christoph Hellwig <[email protected]>
diff -puN include/linux/ioctl32.h~officially-deprecate-register_ioctl32_conversion include/linux/ioctl32.h
--- 25/include/linux/ioctl32.h~officially-deprecate-register_ioctl32_conversion 2005-04-12 03:21:35.863684792 -0700
+++ 25-akpm/include/linux/ioctl32.h 2005-04-12 03:21:35.866684336 -0700
@@ -1,6 +1,8 @@
#ifndef IOCTL32_H
#define IOCTL32_H 1

+#include <linux/compiler.h> /* for __deprecated */
+
struct file;

typedef int (*ioctl_trans_handler_t)(unsigned int, unsigned int,
@@ -23,9 +25,9 @@ struct ioctl_trans {
*/

#ifdef CONFIG_COMPAT
-extern int register_ioctl32_conversion(unsigned int cmd,
+extern int __deprecated register_ioctl32_conversion(unsigned int cmd,
ioctl_trans_handler_t handler);
-extern int unregister_ioctl32_conversion(unsigned int cmd);
+extern int __deprecated unregister_ioctl32_conversion(unsigned int cmd);

#else

_

2005-04-12 22:05:39

by Alexey Dobriyan

Subject: Re: [patch 134/198] officially deprecate register_ioctl32_conversion

On Tuesday 12 April 2005 10:32, [email protected] wrote:

> These have been deprecated since ->compat_ioctl when in, thus only a short
> deprecation period. There's four users left: i2o_config, s390/z90crypy,
> s390/dasd and s390/zfcp and for the first two patches are about to be
> submitted to get rid of it.

> --- 25/Documentation/feature-removal-schedule.txt~officially-deprecate-register_ioctl32_conversion
> +++ 25-akpm/Documentation/feature-removal-schedule.txt

> +Why: Replaced by ->compat_ioctl in file_operations and other method
> + vecors.

vectors ?

2005-04-14 10:49:26

by Christoph Hellwig

Subject: Re: [patch 134/198] officially deprecate register_ioctl32_conversion

On Wed, Apr 13, 2005 at 02:02:42AM +0000, Alexey Dobriyan wrote:
>
> > +Why: Replaced by ->compat_ioctl in file_operations and other method
> > + vecors.
>
> vectors ?

Yes.