2005-04-17 20:22:24

by Adrian Bunk

Subject: [RFC: 2.6 patch] drivers/char/random.c: #if 0 randomize_range

This patch #if 0's the unused global function randomize_range.

Signed-off-by: Adrian Bunk <[email protected]>

---

drivers/char/random.c | 2 ++
include/linux/random.h | 1 -
2 files changed, 2 insertions(+), 1 deletion(-)

--- linux-2.6.12-rc2-mm3-full/include/linux/random.h.old 2005-04-17 18:17:17.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/linux/random.h 2005-04-17 18:17:23.000000000 +0200
@@ -65,7 +65,6 @@
#endif

unsigned int get_random_int(void);
-unsigned long randomize_range(unsigned long start, unsigned long end, unsigned long len);

#endif /* __KERNEL___ */

--- linux-2.6.12-rc2-mm3-full/drivers/char/random.c.old 2005-04-17 18:17:30.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/char/random.c 2005-04-17 18:18:12.000000000 +0200
@@ -1618,6 +1618,7 @@
* a <range> with size "len" starting at the return value is inside in the
* area defined by [start, end], but is otherwise randomized.
*/
+#if 0
unsigned long
randomize_range(unsigned long start, unsigned long end, unsigned long len)
{
@@ -1627,3 +1628,4 @@
return 0;
return PAGE_ALIGN(get_random_int() % range + start);
}
+#endif /* 0 */

2005-04-17 20:44:56

by Matt Mackall

Subject: Re: [RFC: 2.6 patch] drivers/char/random.c: #if 0 randomize_range

On Sun, Apr 17, 2005 at 10:15:37PM +0200, Adrian Bunk wrote:
> This patch #if 0's the unused global function randomize_range.
>

This is presumably for future work in process randomization. Arjan,
what's the status of this bit?

> Signed-off-by: Adrian Bunk <[email protected]>
>
> ---
>
> drivers/char/random.c | 2 ++
> include/linux/random.h | 1 -
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-2.6.12-rc2-mm3-full/include/linux/random.h.old 2005-04-17 18:17:17.000000000 +0200
> +++ linux-2.6.12-rc2-mm3-full/include/linux/random.h 2005-04-17 18:17:23.000000000 +0200
> @@ -65,7 +65,6 @@
> #endif
>
> unsigned int get_random_int(void);
> -unsigned long randomize_range(unsigned long start, unsigned long end, unsigned long len);
>
> #endif /* __KERNEL___ */
>
> --- linux-2.6.12-rc2-mm3-full/drivers/char/random.c.old 2005-04-17 18:17:30.000000000 +0200
> +++ linux-2.6.12-rc2-mm3-full/drivers/char/random.c 2005-04-17 18:18:12.000000000 +0200
> @@ -1618,6 +1618,7 @@
> * a <range> with size "len" starting at the return value is inside in the
> * area defined by [start, end], but is otherwise randomized.
> */
> +#if 0
> unsigned long
> randomize_range(unsigned long start, unsigned long end, unsigned long len)
> {
> @@ -1627,3 +1628,4 @@
> return 0;
> return PAGE_ALIGN(get_random_int() % range + start);
> }
> +#endif /* 0 */

--
Mathematics is the supreme nostalgia of our time.

2005-04-18 07:52:22

by Arjan van de Ven

Subject: Re: [RFC: 2.6 patch] drivers/char/random.c: #if 0 randomize_range

On Sun, Apr 17, 2005 at 01:40:34PM -0700, Matt Mackall wrote:
> On Sun, Apr 17, 2005 at 10:15:37PM +0200, Adrian Bunk wrote:
> > This patch #if 0's the unused global function randomize_range.
> >
>
> This is presumably for future work in process randomization. Arjan,
> what's the status of this bit?

I'll start submitting more randomisation stuff once 2.6.12 gets out; however
I'm more than fine with the #if 0; I'll just remove the if 0's in those
patches when I start using this stuff.