2005-05-12 21:16:20

by Marcelo Tosatti

[permalink] [raw]
Subject: Linux 2.4.31-pre2

Hi,

Here goes 2.4.31-pre2.

It contains a small number of changes, most notably
the elf_core_dump flaw fix (CAN-2005-1263).

Please refer to -hf tree for the standalone patch.

http://linux.exosec.net/kernel/2.4-hf/


Summary of changes from v2.4.31-pre1 to v2.4.31-pre2
============================================

<carlos.pardo:siliconimage.com>:
o sata_sil: Fix FIFO PCI Bus Arbitration

<david.monniaux:ens.fr>:
o fix moxa crash with more than one 1 board

<jason.d.gaston:intel.com>:
o SATA AHCI correction Intel ICH7R

Brett Russ:
o AHCI: fix fatal error int handling
o libata: support descriptor sense in ctrl page

Chris Wright:
o backport v2.6 elf_core_dump() flaw fix (CAN-2005-1263)

Eugene Surovegin:
o ppc32: backport Book-E decrementer handling fix from 2.6

Jean Delvare:
o I2C updates: Fix typo in a comment in i2c.h
o I2C updates: Fix I2C_FUNC_* defines in i2c.h
o I2C updates: Fix an iteration bug in the handling of i2c client module parameters

Jeff Garzik:
o [libata ahci] support ->tf_read hook
o [libata sata_sil] Don't presume PCI cache-line-size reg is > 0

Marcelo Tosatti:
o Change EXTRAVERSION to 2.4.31-pre2

Mikael Pettersson:
o rwsem-spinlock linkage error

Pete Zaitcev:
o USB: Add HX type pl2303

Rolf Eike Beer:
o typo fix in drivers/scsi/sata_svw.c comment

Steven HARDY:
o pcnet32: 79C975 fiber fix

Willy Tarreau:
o bonding fix


2005-05-16 08:36:15

by Willy Tarreau

[permalink] [raw]
Subject: Re: Linux 2.4.31-pre2

Hi Marcelo,

moxa does not compile anymore in 2.4.31-pre2, because a variable is used
before being declared. Since I fixed it on the fly in -hf, I thought that I
had reported it, but I don't find any trace of it, so I might have dreamed...

Here's the fix anyway.
Regards,
Willy

diff -urN linux-2.4.31-pre2/drivers/char/moxa.c linux-2.4.31-pre2-moxa-fix/drivers/char/moxa.c
--- linux-2.4.31-pre2/drivers/char/moxa.c 2005-05-16 10:26:12.000000000 +0200
+++ linux-2.4.31-pre2-moxa-fix/drivers/char/moxa.c 2005-05-16 10:26:29.000000000 +0200
@@ -294,6 +294,7 @@
static int moxa_get_serial_info(struct moxa_str *, struct serial_struct *);
static int moxa_set_serial_info(struct moxa_str *, struct serial_struct *);
static void MoxaSetFifo(int port, int enable);
+static unsigned long moxaIntPend[MAX_BOARDS];

#ifdef MODULE
int init_module(void)
@@ -1579,7 +1580,6 @@

static unsigned char moxaBuff[10240];
static unsigned long moxaIntNdx[MAX_BOARDS];
-static unsigned long moxaIntPend[MAX_BOARDS];
static unsigned long moxaIntTable[MAX_BOARDS];
static char moxaChkPort[MAX_PORTS];
static char moxaLineCtrl[MAX_PORTS];