2005-05-13 22:40:48

by Domen Puncer

Subject: [patch 2/3] drivers/char/hw_random.c: replace direct assignment with set_current_state()

From: Christophe Lucas <[email protected]>



Use set_current_state() instead of direct assignment of
current->state.

Signed-off-by: Christophe Lucas <[email protected]>
Signed-off-by: Domen Puncer <[email protected]>


---
hw_random.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

Index: quilt/drivers/char/hw_random.c
===================================================================
--- quilt.orig/drivers/char/hw_random.c
+++ quilt/drivers/char/hw_random.c
@@ -514,7 +514,7 @@ static ssize_t rng_dev_read (struct file

if(need_resched())
{
- current->state = TASK_INTERRUPTIBLE;
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(1);
}
else

--

2005-05-14 00:34:58

by Jeff Garzik

Subject: Re: [patch 2/3] drivers/char/hw_random.c: replace direct assignment with set_current_state()

[email protected] wrote:
> From: Christophe Lucas <[email protected]>
>
>
>
> Use set_current_state() instead of direct assignment of
> current->state.
>
> Signed-off-by: Christophe Lucas <[email protected]>
> Signed-off-by: Domen Puncer <[email protected]>
>
>
> ---
> hw_random.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: quilt/drivers/char/hw_random.c
> ===================================================================
> --- quilt.orig/drivers/char/hw_random.c
> +++ quilt/drivers/char/hw_random.c
> @@ -514,7 +514,7 @@ static ssize_t rng_dev_read (struct file
>
> if(need_resched())
> {
> - current->state = TASK_INTERRUPTIBLE;
> + set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(1);

full barriers and such don't seem needed.

Also, make sure to send driver patches to the driver author (me).

Jeff