Since kernel 2.6.3 the Kconfig text explicitely stated this driver was
obsolete.
It seems to be time to remove it.
Signed-off-by: Adrian Bunk <[email protected]>
---
drivers/char/Kconfig | 20 --
drivers/char/Makefile | 1
drivers/char/mem.c | 1
drivers/char/raw.c | 342 -----------------------------------
fs/compat_ioctl.c | 69 -------
include/linux/compat_ioctl.h | 3
include/linux/raw.h | 18 -
7 files changed, 454 deletions(-)
--- linux-2.6.12-rc4-mm2-full/drivers/char/Makefile.old 2005-05-21 00:38:42.000000000 +0200
+++ linux-2.6.12-rc4-mm2-full/drivers/char/Makefile 2005-05-21 00:38:47.000000000 +0200
@@ -41,7 +41,6 @@
obj-$(CONFIG_SX) += sx.o generic_serial.o
obj-$(CONFIG_RIO) += rio/ generic_serial.o
obj-$(CONFIG_HVC_CONSOLE) += hvc_console.o hvsi.o
-obj-$(CONFIG_RAW_DRIVER) += raw.o
obj-$(CONFIG_SGI_SNSC) += snsc.o snsc_event.o
obj-$(CONFIG_MMTIMER) += mmtimer.o
obj-$(CONFIG_VIOCONS) += viocons.o
--- linux-2.6.12-rc4-mm2-full/drivers/char/Kconfig.old 2005-05-21 00:38:54.000000000 +0200
+++ linux-2.6.12-rc4-mm2-full/drivers/char/Kconfig 2005-05-21 00:39:03.000000000 +0200
@@ -929,17 +929,6 @@
If compiled as a module, it will be called scx200_gpio.
-config RAW_DRIVER
- tristate "RAW driver (/dev/raw/rawN) (OBSOLETE)"
- help
- The raw driver permits block devices to be bound to /dev/raw/rawN.
- Once bound, I/O against /dev/raw/rawN uses efficient zero-copy I/O.
- See the raw(8) manpage for more details.
-
- The raw driver is deprecated and may be removed from 2.7
- kernels. Applications should simply open the device (eg /dev/hda1)
- with the O_DIRECT flag.
-
config HPET
bool "HPET - High Precision Event Timer" if (X86 || IA64)
default n
@@ -971,15 +960,6 @@
exposed to the user. If this applies to your hardware,
say N here.
-config MAX_RAW_DEVS
- int "Maximum number of RAW devices to support (1-8192)"
- depends on RAW_DRIVER
- default "256"
- help
- The maximum number of RAW devices that are supported.
- Default is 256. Increase this number in case you need lots of
- raw devices.
-
config HANGCHECK_TIMER
tristate "Hangcheck timer"
depends on X86_64 || X86 || IA64 || PPC64 || ARCH_S390
--- linux-2.6.12-rc4-mm2-full/include/linux/compat_ioctl.h.old 2005-05-21 00:39:17.000000000 +0200
+++ linux-2.6.12-rc4-mm2-full/include/linux/compat_ioctl.h 2005-05-21 00:39:28.000000000 +0200
@@ -574,9 +574,6 @@
COMPATIBLE_IOCTL(DEVFSDIOC_SET_EVENT_MASK)
COMPATIBLE_IOCTL(DEVFSDIOC_RELEASE_EVENT_QUEUE)
COMPATIBLE_IOCTL(DEVFSDIOC_SET_DEBUG_MASK)
-/* Raw devices */
-COMPATIBLE_IOCTL(RAW_SETBIND)
-COMPATIBLE_IOCTL(RAW_GETBIND)
/* SMB ioctls which do not need any translations */
COMPATIBLE_IOCTL(SMB_IOC_NEWCONN)
/* NCP ioctls which do not need any translations */
--- linux-2.6.12-rc4-mm2-full/fs/compat_ioctl.c.old 2005-05-21 00:39:35.000000000 +0200
+++ linux-2.6.12-rc4-mm2-full/fs/compat_ioctl.c 2005-05-21 00:41:28.000000000 +0200
@@ -51,7 +51,6 @@
#include <linux/ext2_fs.h>
#include <linux/videodev.h>
#include <linux/netdevice.h>
-#include <linux/raw.h>
#include <linux/smb_fs.h>
#include <linux/blkpg.h>
#include <linux/blkdev.h>
@@ -2331,71 +2330,6 @@
return sys_ioctl(fd,cmd,ptr);
}
-struct raw32_config_request
-{
- compat_int_t raw_minor;
- __u64 block_major;
- __u64 block_minor;
-} __attribute__((packed));
-
-static int get_raw32_request(struct raw_config_request *req, struct raw32_config_request __user *user_req)
-{
- int ret;
-
- if (!access_ok(VERIFY_READ, user_req, sizeof(struct raw32_config_request)))
- return -EFAULT;
-
- ret = __get_user(req->raw_minor, &user_req->raw_minor);
- ret |= __get_user(req->block_major, &user_req->block_major);
- ret |= __get_user(req->block_minor, &user_req->block_minor);
-
- return ret ? -EFAULT : 0;
-}
-
-static int set_raw32_request(struct raw_config_request *req, struct raw32_config_request __user *user_req)
-{
- int ret;
-
- if (!access_ok(VERIFY_WRITE, user_req, sizeof(struct raw32_config_request)))
- return -EFAULT;
-
- ret = __put_user(req->raw_minor, &user_req->raw_minor);
- ret |= __put_user(req->block_major, &user_req->block_major);
- ret |= __put_user(req->block_minor, &user_req->block_minor);
-
- return ret ? -EFAULT : 0;
-}
-
-static int raw_ioctl(unsigned fd, unsigned cmd, unsigned long arg)
-{
- int ret;
-
- switch (cmd) {
- case RAW_SETBIND:
- case RAW_GETBIND: {
- struct raw_config_request req;
- struct raw32_config_request __user *user_req = compat_ptr(arg);
- mm_segment_t oldfs = get_fs();
-
- if ((ret = get_raw32_request(&req, user_req)))
- return ret;
-
- set_fs(KERNEL_DS);
- ret = sys_ioctl(fd,cmd,(unsigned long)&req);
- set_fs(oldfs);
-
- if ((!ret) && (cmd == RAW_GETBIND)) {
- ret = set_raw32_request(&req, user_req);
- }
- break;
- }
- default:
- ret = sys_ioctl(fd, cmd, arg);
- break;
- }
- return ret;
-}
-
struct serial_struct32 {
compat_int_t type;
compat_int_t line;
@@ -3037,9 +2971,6 @@
HANDLE_IOCTL(VFAT_IOCTL_READDIR_BOTH32, vfat_ioctl32)
HANDLE_IOCTL(VFAT_IOCTL_READDIR_SHORT32, vfat_ioctl32)
HANDLE_IOCTL(REISERFS_IOC_UNPACK32, reiserfs_ioctl32)
-/* Raw devices */
-HANDLE_IOCTL(RAW_SETBIND, raw_ioctl)
-HANDLE_IOCTL(RAW_GETBIND, raw_ioctl)
/* Serial */
HANDLE_IOCTL(TIOCGSERIAL, serial_struct_ioctl)
HANDLE_IOCTL(TIOCSSERIAL, serial_struct_ioctl)
--- linux-2.6.12-rc4-mm2-full/drivers/char/mem.c.old 2005-05-21 00:42:07.000000000 +0200
+++ linux-2.6.12-rc4-mm2-full/drivers/char/mem.c 2005-05-21 00:42:11.000000000 +0200
@@ -16,7 +16,6 @@
#include <linux/mman.h>
#include <linux/random.h>
#include <linux/init.h>
-#include <linux/raw.h>
#include <linux/tty.h>
#include <linux/capability.h>
#include <linux/smp_lock.h>
--- linux-2.6.12-rc4-mm2-full/include/linux/raw.h 2005-03-02 08:38:13.000000000 +0100
+++ /dev/null 2005-04-28 03:52:17.000000000 +0200
@@ -1,18 +0,0 @@
-#ifndef __LINUX_RAW_H
-#define __LINUX_RAW_H
-
-#include <linux/types.h>
-
-#define RAW_SETBIND _IO( 0xac, 0 )
-#define RAW_GETBIND _IO( 0xac, 1 )
-
-struct raw_config_request
-{
- int raw_minor;
- __u64 block_major;
- __u64 block_minor;
-};
-
-#define MAX_RAW_MINORS CONFIG_MAX_RAW_DEVS
-
-#endif /* __LINUX_RAW_H */
--- linux-2.6.12-rc4-mm2-full/drivers/char/raw.c 2005-05-16 12:16:58.000000000 +0200
+++ /dev/null 2005-04-28 03:52:17.000000000 +0200
@@ -1,342 +0,0 @@
-/*
- * linux/drivers/char/raw.c
- *
- * Front-end raw character devices. These can be bound to any block
- * devices to provide genuine Unix raw character device semantics.
- *
- * We reserve minor number 0 for a control interface. ioctl()s on this
- * device are used to bind the other minor numbers to block devices.
- */
-
-#include <linux/init.h>
-#include <linux/fs.h>
-#include <linux/devfs_fs_kernel.h>
-#include <linux/major.h>
-#include <linux/blkdev.h>
-#include <linux/module.h>
-#include <linux/raw.h>
-#include <linux/capability.h>
-#include <linux/uio.h>
-#include <linux/cdev.h>
-#include <linux/device.h>
-
-#include <asm/uaccess.h>
-
-struct raw_device_data {
- struct block_device *binding;
- int inuse;
-};
-
-static struct class *raw_class;
-static struct raw_device_data raw_devices[MAX_RAW_MINORS];
-static DECLARE_MUTEX(raw_mutex);
-static struct file_operations raw_ctl_fops; /* forward declaration */
-
-/*
- * Open/close code for raw IO.
- *
- * We just rewrite the i_mapping for the /dev/raw/rawN file descriptor to
- * point at the blockdev's address_space and set the file handle to use
- * O_DIRECT.
- *
- * Set the device's soft blocksize to the minimum possible. This gives the
- * finest possible alignment and has no adverse impact on performance.
- */
-static int raw_open(struct inode *inode, struct file *filp)
-{
- const int minor = iminor(inode);
- struct block_device *bdev;
- int err;
-
- if (minor == 0) { /* It is the control device */
- filp->f_op = &raw_ctl_fops;
- return 0;
- }
-
- down(&raw_mutex);
-
- /*
- * All we need to do on open is check that the device is bound.
- */
- bdev = raw_devices[minor].binding;
- err = -ENODEV;
- if (!bdev)
- goto out;
- igrab(bdev->bd_inode);
- err = blkdev_get(bdev, filp->f_mode, 0);
- if (err)
- goto out;
- err = bd_claim(bdev, raw_open);
- if (err)
- goto out1;
- err = set_blocksize(bdev, bdev_hardsect_size(bdev));
- if (err)
- goto out2;
- filp->f_flags |= O_DIRECT;
- filp->f_mapping = bdev->bd_inode->i_mapping;
- if (++raw_devices[minor].inuse == 1)
- filp->f_dentry->d_inode->i_mapping =
- bdev->bd_inode->i_mapping;
- filp->private_data = bdev;
- up(&raw_mutex);
- return 0;
-
-out2:
- bd_release(bdev);
-out1:
- blkdev_put(bdev);
-out:
- up(&raw_mutex);
- return err;
-}
-
-/*
- * When the final fd which refers to this character-special node is closed, we
- * make its ->mapping point back at its own i_data.
- */
-static int raw_release(struct inode *inode, struct file *filp)
-{
- const int minor= iminor(inode);
- struct block_device *bdev;
-
- down(&raw_mutex);
- bdev = raw_devices[minor].binding;
- if (--raw_devices[minor].inuse == 0) {
- /* Here inode->i_mapping == bdev->bd_inode->i_mapping */
- inode->i_mapping = &inode->i_data;
- inode->i_mapping->backing_dev_info = &default_backing_dev_info;
- }
- up(&raw_mutex);
-
- bd_release(bdev);
- blkdev_put(bdev);
- return 0;
-}
-
-/*
- * Forward ioctls to the underlying block device.
- */
-static int
-raw_ioctl(struct inode *inode, struct file *filp,
- unsigned int command, unsigned long arg)
-{
- struct block_device *bdev = filp->private_data;
-
- return ioctl_by_bdev(bdev, command, arg);
-}
-
-static void bind_device(struct raw_config_request *rq)
-{
- class_device_destroy(raw_class, MKDEV(RAW_MAJOR, rq->raw_minor));
- class_device_create(raw_class, MKDEV(RAW_MAJOR, rq->raw_minor),
- NULL, "raw%d", rq->raw_minor);
-}
-
-/*
- * Deal with ioctls against the raw-device control interface, to bind
- * and unbind other raw devices.
- */
-static int raw_ctl_ioctl(struct inode *inode, struct file *filp,
- unsigned int command, unsigned long arg)
-{
- struct raw_config_request rq;
- struct raw_device_data *rawdev;
- int err = 0;
-
- switch (command) {
- case RAW_SETBIND:
- case RAW_GETBIND:
-
- /* First, find out which raw minor we want */
-
- if (copy_from_user(&rq, (void __user *) arg, sizeof(rq))) {
- err = -EFAULT;
- goto out;
- }
-
- if (rq.raw_minor < 0 || rq.raw_minor >= MAX_RAW_MINORS) {
- err = -EINVAL;
- goto out;
- }
- rawdev = &raw_devices[rq.raw_minor];
-
- if (command == RAW_SETBIND) {
- dev_t dev;
-
- /*
- * This is like making block devices, so demand the
- * same capability
- */
- if (!capable(CAP_SYS_ADMIN)) {
- err = -EPERM;
- goto out;
- }
-
- /*
- * For now, we don't need to check that the underlying
- * block device is present or not: we can do that when
- * the raw device is opened. Just check that the
- * major/minor numbers make sense.
- */
-
- dev = MKDEV(rq.block_major, rq.block_minor);
- if ((rq.block_major == 0 && rq.block_minor != 0) ||
- MAJOR(dev) != rq.block_major ||
- MINOR(dev) != rq.block_minor) {
- err = -EINVAL;
- goto out;
- }
-
- down(&raw_mutex);
- if (rawdev->inuse) {
- up(&raw_mutex);
- err = -EBUSY;
- goto out;
- }
- if (rawdev->binding) {
- bdput(rawdev->binding);
- module_put(THIS_MODULE);
- }
- if (rq.block_major == 0 && rq.block_minor == 0) {
- /* unbind */
- rawdev->binding = NULL;
- class_device_destroy(raw_class,
- MKDEV(RAW_MAJOR, rq.raw_minor));
- } else {
- rawdev->binding = bdget(dev);
- if (rawdev->binding == NULL)
- err = -ENOMEM;
- else {
- __module_get(THIS_MODULE);
- bind_device(&rq);
- }
- }
- up(&raw_mutex);
- } else {
- struct block_device *bdev;
-
- down(&raw_mutex);
- bdev = rawdev->binding;
- if (bdev) {
- rq.block_major = MAJOR(bdev->bd_dev);
- rq.block_minor = MINOR(bdev->bd_dev);
- } else {
- rq.block_major = rq.block_minor = 0;
- }
- up(&raw_mutex);
- if (copy_to_user((void __user *)arg, &rq, sizeof(rq))) {
- err = -EFAULT;
- goto out;
- }
- }
- break;
- default:
- err = -EINVAL;
- break;
- }
-out:
- return err;
-}
-
-static ssize_t raw_file_write(struct file *file, const char __user *buf,
- size_t count, loff_t *ppos)
-{
- struct iovec local_iov = {
- .iov_base = (char __user *)buf,
- .iov_len = count
- };
-
- return generic_file_write_nolock(file, &local_iov, 1, ppos);
-}
-
-static ssize_t raw_file_aio_write(struct kiocb *iocb, const char __user *buf,
- size_t count, loff_t pos)
-{
- struct iovec local_iov = {
- .iov_base = (char __user *)buf,
- .iov_len = count
- };
-
- return generic_file_aio_write_nolock(iocb, &local_iov, 1, &iocb->ki_pos);
-}
-
-
-static struct file_operations raw_fops = {
- .read = generic_file_read,
- .aio_read = generic_file_aio_read,
- .write = raw_file_write,
- .aio_write = raw_file_aio_write,
- .open = raw_open,
- .release= raw_release,
- .ioctl = raw_ioctl,
- .readv = generic_file_readv,
- .writev = generic_file_writev,
- .owner = THIS_MODULE,
-};
-
-static struct file_operations raw_ctl_fops = {
- .ioctl = raw_ctl_ioctl,
- .open = raw_open,
- .owner = THIS_MODULE,
-};
-
-static struct cdev raw_cdev = {
- .kobj = {.name = "raw", },
- .owner = THIS_MODULE,
-};
-
-static int __init raw_init(void)
-{
- int i;
- dev_t dev = MKDEV(RAW_MAJOR, 0);
-
- if (register_chrdev_region(dev, MAX_RAW_MINORS, "raw"))
- goto error;
-
- cdev_init(&raw_cdev, &raw_fops);
- if (cdev_add(&raw_cdev, dev, MAX_RAW_MINORS)) {
- kobject_put(&raw_cdev.kobj);
- unregister_chrdev_region(dev, MAX_RAW_MINORS);
- goto error;
- }
-
- raw_class = class_create(THIS_MODULE, "raw");
- if (IS_ERR(raw_class)) {
- printk(KERN_ERR "Error creating raw class.\n");
- cdev_del(&raw_cdev);
- unregister_chrdev_region(dev, MAX_RAW_MINORS);
- goto error;
- }
- class_device_create(raw_class, MKDEV(RAW_MAJOR, 0), NULL, "rawctl");
-
- devfs_mk_cdev(MKDEV(RAW_MAJOR, 0),
- S_IFCHR | S_IRUGO | S_IWUGO,
- "raw/rawctl");
- for (i = 1; i < MAX_RAW_MINORS; i++)
- devfs_mk_cdev(MKDEV(RAW_MAJOR, i),
- S_IFCHR | S_IRUGO | S_IWUGO,
- "raw/raw%d", i);
- return 0;
-
-error:
- printk(KERN_ERR "error register raw device\n");
- return 1;
-}
-
-static void __exit raw_exit(void)
-{
- int i;
-
- for (i = 1; i < MAX_RAW_MINORS; i++)
- devfs_remove("raw/raw%d", i);
- devfs_remove("raw/rawctl");
- devfs_remove("raw");
- class_device_destroy(raw_class, MKDEV(RAW_MAJOR, 0));
- class_destroy(raw_class);
- cdev_del(&raw_cdev);
- unregister_chrdev_region(MKDEV(RAW_MAJOR, 0), MAX_RAW_MINORS);
-}
-
-module_init(raw_init);
-module_exit(raw_exit);
-MODULE_LICENSE("GPL");
> Since kernel 2.6.3 the Kconfig text explicitely stated this driver was
> obsolete.
>
> It seems to be time to remove it.
Disagree. We need someone to benchmark and prove O_DIRECT on the raw
device isnt a performance regression first.
Anton
On Friday, May 20, 2005 5:43 pm, Anton Blanchard wrote:
> > Since kernel 2.6.3 the Kconfig text explicitely stated this driver
> > was obsolete.
> >
> > It seems to be time to remove it.
>
> Disagree. We need someone to benchmark and prove O_DIRECT on the raw
> device isnt a performance regression first.
I don't have data on hand, but I recall seeing O_DIRECT on block devices
(at least SCSI ones), attaining something very close to line rate, and
scaling quite well as I/O was added.
Jesse
On Sat, May 21, 2005 at 02:19:25AM +0200, Adrian Bunk wrote:
> Since kernel 2.6.3 the Kconfig text explicitely stated this driver was
> obsolete.
> It seems to be time to remove it.
> Signed-off-by: Adrian Bunk <[email protected]>
9 point releases is nowhere long enough. This removal needs to wait for
similar amounts of time as other removed interfaces (c.f. devfs, which
is far more offensive).
In general there are staging rules for this sort of affair, and although
I'm no expert in their fine points, nor can I even say what the exact
criteria are, but it's rather clear in this instance it's over the line.
I suspect a major release, planned as a staging ground for things like
e.g. this and removing devfs, would be the most appropriate time for it.
-- wli
On Sat, May 21, 2005 at 02:19:25AM +0200, Adrian Bunk wrote:
> Since kernel 2.6.3 the Kconfig text explicitely stated this driver was
> obsolete.
>
> It seems to be time to remove it.
As much as I would like to agree with you, no, not yet. Mark it as
going to go away in the Documenation/feature-removal.txt file 6-8 months
from now (or longer if people object, but no longer than a year) and
then after that time expires, we can delete it.
thanks,
greg k-h
On Fri, May 20, 2005 at 06:25:05PM -0700, William Lee Irwin III wrote:
> On Sat, May 21, 2005 at 02:19:25AM +0200, Adrian Bunk wrote:
> > Since kernel 2.6.3 the Kconfig text explicitely stated this driver was
> > obsolete.
> > It seems to be time to remove it.
> > Signed-off-by: Adrian Bunk <[email protected]>
>
> 9 point releases is nowhere long enough. This removal needs to wait for
> similar amounts of time as other removed interfaces (c.f. devfs, which
> is far more offensive).
>
> In general there are staging rules for this sort of affair, and although
> I'm no expert in their fine points, nor can I even say what the exact
> criteria are, but it's rather clear in this instance it's over the line.
> I suspect a major release, planned as a staging ground for things like
> e.g. this and removing devfs, would be the most appropriate time for it.
The current rules are simply "put it for 6-12 months in
Documentation/feature-removal-schedule.txt and remove it then".
2.6.3 is more than a year go, and the date when the raw driver was
declared obsolete predates the introduction of
feature-removal-schedule.txt (at that time, we were still in the belief
a 2.7 kernel would come some day).
> -- wli
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Fri, May 20, 2005 at 06:25:05PM -0700, William Lee Irwin III wrote:
>> 9 point releases is nowhere long enough. This removal needs to wait for
>> similar amounts of time as other removed interfaces (c.f. devfs, which
>> is far more offensive).
>> In general there are staging rules for this sort of affair, and although
>> I'm no expert in their fine points, nor can I even say what the exact
>> criteria are, but it's rather clear in this instance it's over the line.
>> I suspect a major release, planned as a staging ground for things like
>> e.g. this and removing devfs, would be the most appropriate time for it.
On Sat, May 21, 2005 at 09:41:10AM +0200, Adrian Bunk wrote:
> The current rules are simply "put it for 6-12 months in
> Documentation/feature-removal-schedule.txt and remove it then".
> 2.6.3 is more than a year go, and the date when the raw driver was
> declared obsolete predates the introduction of
> feature-removal-schedule.txt (at that time, we were still in the belief
> a 2.7 kernel would come some day).
This sounds a little shaky but I'll let someone higher up roll dice or
whatever to decide.
-- wli
Hi,
On Fri, 20 May 2005, Greg KH wrote:
> On Sat, May 21, 2005 at 02:19:25AM +0200, Adrian Bunk wrote:
> > Since kernel 2.6.3 the Kconfig text explicitely stated this driver was
> > obsolete.
> >
> > It seems to be time to remove it.
>
> As much as I would like to agree with you, no, not yet. Mark it as
> going to go away in the Documenation/feature-removal.txt file 6-8 months
> from now (or longer if people object, but no longer than a year) and
> then after that time expires, we can delete it.
Adding a warning message to the open function would be nice too.
Which user really reads that file?
bye, Roman
Adrian Bunk <[email protected]> said:
> Since kernel 2.6.3 the Kconfig text explicitely stated this driver was
> obsolete.
>
> It seems to be time to remove it.
[...]
> - The raw driver is deprecated and may be removed from 2.7
> - kernels. Applications should simply open the device (eg /dev/hda1)
> - with the O_DIRECT flag.
To me, this sounds like a promise to keep it around for 2.6 at least...
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513
On Fri, May 20, 2005 at 08:45:08PM -0400, Horst von Brand wrote:
> Adrian Bunk <[email protected]> said:
> > Since kernel 2.6.3 the Kconfig text explicitely stated this driver was
> > obsolete.
> >
> > It seems to be time to remove it.
>
> [...]
>
> > - The raw driver is deprecated and may be removed from 2.7
> > - kernels. Applications should simply open the device (eg /dev/hda1)
> > - with the O_DIRECT flag.
>
> To me, this sounds like a promise to keep it around for 2.6 at least...
With the current development model, 2.7 is a synonym for 2.6.12 ...
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed