2005-05-26 11:16:19

by Olaf Hering

[permalink] [raw]
Subject: [PATCH] show swsuspend only on .config where it can compile

show swsuspend only on .config where it can compile.
I got this on PPC32 && SMP

kernel/power/smp.c:24: error: storage size of `ctxt' isn't known

Signed-off-by: Olaf Hering <[email protected]>

Index: linux-2.6.12-rc5-olh/kernel/power/Kconfig
===================================================================
--- linux-2.6.12-rc5-olh.orig/kernel/power/Kconfig
+++ linux-2.6.12-rc5-olh/kernel/power/Kconfig
@@ -28,7 +28,7 @@ config PM_DEBUG

config SOFTWARE_SUSPEND
bool "Software Suspend (EXPERIMENTAL)"
- depends on EXPERIMENTAL && PM && SWAP
+ depends on EXPERIMENTAL && PM && SWAP && (X86 && SMP) || ((FVR || PPC32 || X86) && !SMP)
---help---
Enable the possibility of suspending the machine.
It doesn't need APM.


2005-05-26 11:46:36

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH] show swsuspend only on .config where it can compile

On Čt 26-05-05 13:16:14, Olaf Hering wrote:
> show swsuspend only on .config where it can compile.
> I got this on PPC32 && SMP
>
> kernel/power/smp.c:24: error: storage size of `ctxt' isn't known
>
> Signed-off-by: Olaf Hering <[email protected]>

Thanks, applied. Also swsusp is pretty stable now, so I'll mark it as
stable.
Pavel

2005-05-26 12:49:19

by Romano Giannetti

[permalink] [raw]
Subject: Re: [PATCH] show swsuspend only on .config where it can compile

On Thu, May 26, 2005 at 01:16:14PM +0200, Olaf Hering wrote:
> show swsuspend only on .config where it can compile.
> I got this on PPC32 && SMP
>
> kernel/power/smp.c:24: error: storage size of `ctxt' isn't known
>
> Signed-off-by: Olaf Hering <[email protected]>
>
> Index: linux-2.6.12-rc5-olh/kernel/power/Kconfig
> ===================================================================
> --- linux-2.6.12-rc5-olh.orig/kernel/power/Kconfig
> +++ linux-2.6.12-rc5-olh/kernel/power/Kconfig
> @@ -28,7 +28,7 @@ config PM_DEBUG
>
> config SOFTWARE_SUSPEND
> bool "Software Suspend (EXPERIMENTAL)"
> - depends on EXPERIMENTAL && PM && SWAP
> + depends on EXPERIMENTAL && PM && SWAP && (X86 && SMP) || ((FVR || PPC32 || X86) && !SMP)

Shouldn't be ...&& ( (X86 && SMP) || (FVR || PPC32 || X86) && !SMP ) ?

and maybe

EXPERIMENTAL && PM && SWAP && ( X86 || ((FVR || PPC32) && !SMP) )

is clearer?



--
Romano Giannetti - Univ. Pontificia Comillas (Madrid, Spain)
Electronic Engineer - phone +34 915 422 800 ext 2416 fax +34 915 596 569

2005-05-26 13:56:02

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH] show swsuspend only on .config where it can compile

Hi!

> > kernel/power/smp.c:24: error: storage size of `ctxt' isn't known
> >
> > Signed-off-by: Olaf Hering <[email protected]>
> >
> > Index: linux-2.6.12-rc5-olh/kernel/power/Kconfig
> > ===================================================================
> > --- linux-2.6.12-rc5-olh.orig/kernel/power/Kconfig
> > +++ linux-2.6.12-rc5-olh/kernel/power/Kconfig
> > @@ -28,7 +28,7 @@ config PM_DEBUG
> >
> > config SOFTWARE_SUSPEND
> > bool "Software Suspend (EXPERIMENTAL)"
> > - depends on EXPERIMENTAL && PM && SWAP
> > + depends on EXPERIMENTAL && PM && SWAP && (X86 && SMP) || ((FVR || PPC32 || X86) && !SMP)
>
> Shouldn't be ...&& ( (X86 && SMP) || (FVR || PPC32 || X86) && !SMP )
> > ?

Missing parenthesis added, thanks.
Pavel