2005-05-27 09:26:44

by Frank Pavlic

Subject: [patch 4/10] s390: schedule_timeout cleanup in ctctty

[patch 4/10] s390: schedule_timeout cleanup in ctctty.

From: Domen Puncer <[email protected]>

Use msleep_interruptible() instead of schedule_timeout()
to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <[email protected]>
Signed-off-by: Maximilian Attems <[email protected]>
Signed-off-by: Domen Puncer <[email protected]>
Signed-off-by: Frank Pavlic <[email protected]>
Acked-by: Martin Schwidefsky <[email protected]>

diffstat:
drivers/s390/net/ctctty.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff -urpN linux-2.6/drivers/s390/net/ctctty.c linux-2.6-patched/drivers/s390/net/ctctty.c
--- linux-2.6/drivers/s390/net/ctctty.c 2005-05-06 11:25:57.000000000 +0200
+++ linux-2.6-patched/drivers/s390/net/ctctty.c 2005-05-06 11:26:14.000000000 +0200
@@ -1,5 +1,5 @@
/*
- * $Id: ctctty.c,v 1.26 2004/08/04 11:06:55 mschwide Exp $
+ * $Id: ctctty.c,v 1.29 2005/04/05 08:50:44 mschwide Exp $
*
* CTC / ESCON network driver, tty interface.
*
@@ -1056,8 +1056,7 @@ ctc_tty_close(struct tty_struct *tty, st
info->tty = 0;
tty->closing = 0;
if (info->blocked_open) {
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(HZ/2);
+ msleep_interruptible(500);
wake_up_interruptible(&info->open_wait);
}
info->flags &= ~(CTC_ASYNC_NORMAL_ACTIVE | CTC_ASYNC_CLOSING);

2005-05-28 09:53:30

by Domen Puncer

Subject: Re: [patch 4/10] s390: schedule_timeout cleanup in ctctty

On 27/05/05 11:02 +0200, Frank Pavlic wrote:
>
> [patch 4/10] s390: schedule_timeout cleanup in ctctty.
>
> From: Domen Puncer <[email protected]>
>
> Use msleep_interruptible() instead of schedule_timeout()
> to guarantee the task delays as expected.
>
> Signed-off-by: Nishanth Aravamudan <[email protected]>

Actually it's from:
Nishanth Aravamudan <[email protected]>

Since then, I updated scripts to add the "From: " in the
body, so this shouldn't be an issue in the future.

> Signed-off-by: Maximilian Attems <[email protected]>
> Signed-off-by: Domen Puncer <[email protected]>
> Signed-off-by: Frank Pavlic <[email protected]>
> Acked-by: Martin Schwidefsky <[email protected]>
>


Domen

2005-05-29 09:22:30

by Frank Pavlic

Subject: Re: [patch 4/10] s390: schedule_timeout cleanup in ctctty

Domen Puncer <[email protected]> wrote on 28.05.2005 11:53:18:

> On 27/05/05 11:02 +0200, Frank Pavlic wrote:
> >
> > [patch 4/10] s390: schedule_timeout cleanup in ctctty.
> >
> > From: Domen Puncer <[email protected]>
> >
> > Use msleep_interruptible() instead of schedule_timeout()
> > to guarantee the task delays as expected.
> >
> > Signed-off-by: Nishanth Aravamudan <[email protected]>
>
> Actually it's from:
> Nishanth Aravamudan <[email protected]>
>
> Since then, I updated scripts to add the "From: " in the
> body, so this shouldn't be an issue in the future.
>
> > Signed-off-by: Maximilian Attems <[email protected]>
> > Signed-off-by: Domen Puncer <[email protected]>
> > Signed-off-by: Frank Pavlic <[email protected]>
> > Acked-by: Martin Schwidefsky <[email protected]>
> >
>
>
> Domen

thank you for the correction ....

Frank