2005-04-12 12:27:25

by Rene Herman

[permalink] [raw]
Subject: 2.6.12-rc2: Compose key doesn't work

Hi Vojtech.

I have mapped my right windows key to "Compose" in X:

Section "InputDevice"
Identifier "Keyboard0"
Driver "kbd"
Option "XkbModel" "pc104"
Option "XkbLayout" "us"
Option "XkbOptions" "compose:rwin"
EndSection

This worked fine upto 2.6.11.7, but doesn't under 2.6.12-rc2. The key
doesn't seem to be doing anything anymore: "Compose-'-e" just gets me
"'e" and so on.

X is X.org 6.8.1, keyboard is regular PS/2 keyboard, directly connected.

Rene.


2005-04-14 10:05:09

by Domen Puncer

[permalink] [raw]
Subject: Re: 2.6.12-rc2: Compose key doesn't work

On 10/04/05 11:52 +0200, Rene Herman wrote:
> Hi Vojtech.
>
> I have mapped my right windows key to "Compose" in X:
...
>
> This worked fine upto 2.6.11.7, but doesn't under 2.6.12-rc2. The key
> doesn't seem to be doing anything anymore: "Compose-'-e" just gets me
> "'e" and so on.

I can confirm this, right windows key works as scroll up, so it might
be related to recent scroll patches.

A quick workaround is to:
echo -n "0" > /sys/bus/serio/devices/serio1/scroll

serio1 being the keyboard here.

Btw. is that "-n" really necessary? Had too look at the code to figure
out why it's not working :-)

>
> X is X.org 6.8.1, keyboard is regular PS/2 keyboard, directly connected.

Same here.


Domen

2005-04-14 11:19:44

by Kees Bakker

[permalink] [raw]
Subject: Re: 2.6.12-rc2: Compose key doesn't work

Rene Herman wrote:

> Hi Vojtech.
>
> I have mapped my right windows key to "Compose" in X:
>
> Section "InputDevice"
> Identifier "Keyboard0"
> Driver "kbd"
> Option "XkbModel" "pc104"
> Option "XkbLayout" "us"
> Option "XkbOptions" "compose:rwin"
> EndSection
>
> This worked fine upto 2.6.11.7, but doesn't under 2.6.12-rc2. The key
> doesn't seem to be doing anything anymore: "Compose-'-e" just gets me
> "'e" and so on.

This is caused by the change in drivers/input/keyboard/atkbd.c
By default atkbd_scroll is now set 1. This can be switched off on the
commandline if you want to try: atkbd.scroll=0

I'd vote for undoing the change. Here is a tiny patch.
diff -Nru a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
--- a/drivers/input/keyboard/atkbd.c????2005-04-04?09:40:48?-07:00
+++ b/drivers/input/keyboard/atkbd.c????2005-04-04?09:40:48?-07:00
@@ -54,7 +54,7 @@
?module_param_named(softraw,?atkbd_softraw,?bool,?0);
?MODULE_PARM_DESC(softraw,?"Use?software?generated?rawmode");

-static int atkbd_scroll = 1;
+static int atkbd_scroll;
?module_param_named(scroll,?atkbd_scroll,?bool,?0);
?MODULE_PARM_DESC(scroll,?"Enable?scroll-wheel?on?MS?Office?and?similar?keyboards");




2005-05-26 12:23:28

by Domen Puncer

[permalink] [raw]
Subject: Re: 2.6.12-rc2: Compose key doesn't work

Still true for 2.6.12-rc5. Should probably be fixed before final.

On 14/04/05 12:04 +0200, Domen Puncer wrote:
> On 10/04/05 11:52 +0200, Rene Herman wrote:
> > Hi Vojtech.
> >
> > I have mapped my right windows key to "Compose" in X:
> ...
> >
> > This worked fine upto 2.6.11.7, but doesn't under 2.6.12-rc2. The key
> > doesn't seem to be doing anything anymore: "Compose-'-e" just gets me
> > "'e" and so on.
>
> I can confirm this, right windows key works as scroll up, so it might
> be related to recent scroll patches.
>
> A quick workaround is to:
> echo -n "0" > /sys/bus/serio/devices/serio1/scroll
>
> serio1 being the keyboard here.
>
> Btw. is that "-n" really necessary? Had too look at the code to figure
> out why it's not working :-)
>
> >
> > X is X.org 6.8.1, keyboard is regular PS/2 keyboard, directly connected.
>
> Same here.

2005-05-26 12:27:34

by Vojtech Pavlik

[permalink] [raw]
Subject: Re: 2.6.12-rc2: Compose key doesn't work

On Thu, May 26, 2005 at 02:23:15PM +0200, Domen Puncer wrote:

> Still true for 2.6.12-rc5. Should probably be fixed before final.

Caused by a bug in the atkbd-scroll feature. The attached patch
fixes it.

> On 14/04/05 12:04 +0200, Domen Puncer wrote:
> > On 10/04/05 11:52 +0200, Rene Herman wrote:
> > > Hi Vojtech.
> > >
> > > I have mapped my right windows key to "Compose" in X:
> > ...
> > >
> > > This worked fine upto 2.6.11.7, but doesn't under 2.6.12-rc2. The key
> > > doesn't seem to be doing anything anymore: "Compose-'-e" just gets me
> > > "'e" and so on.
> >
> > I can confirm this, right windows key works as scroll up, so it might
> > be related to recent scroll patches.
> >
> > A quick workaround is to:
> > echo -n "0" > /sys/bus/serio/devices/serio1/scroll
> >
> > serio1 being the keyboard here.
> >
> > Btw. is that "-n" really necessary? Had too look at the code to figure
> > out why it's not working :-)
> >
> > >
> > > X is X.org 6.8.1, keyboard is regular PS/2 keyboard, directly connected.
> >
> > Same here.
>

--
Vojtech Pavlik
SuSE Labs, SuSE CR


Attachments:
(No filename) (1.07 kB)
atkbd-fix-scroll (809.00 B)
Download all attachments

2005-05-26 15:48:40

by Wakko Warner

[permalink] [raw]
Subject: Re: 2.6.12-rc2: Compose key doesn't work

Domen Puncer wrote:
> Still true for 2.6.12-rc5. Should probably be fixed before final.

I also have a problem with 2.6.12-rcX and ps/2 keyboard. I would say it's
the same key we're talking about. It does not work at the console nor in X
(showkey at the console does not see it). It works with a USB keyboard. My
"compose" is mapped to the menu key beside the right windows key.

I do wish they'd fix it, because I use this key (kinda like another ALT key)
more than my compose key (again, the menu key, not the right win logo key)

> > On 10/04/05 11:52 +0200, Rene Herman wrote:
> > > Hi Vojtech.
> > >
> > > I have mapped my right windows key to "Compose" in X:
> > ...
> > >
> > > This worked fine upto 2.6.11.7, but doesn't under 2.6.12-rc2. The key
> > > doesn't seem to be doing anything anymore: "Compose-'-e" just gets me
> > > "'e" and so on.
> >
> > I can confirm this, right windows key works as scroll up, so it might
> > be related to recent scroll patches.
> >
> > A quick workaround is to:
> > echo -n "0" > /sys/bus/serio/devices/serio1/scroll
> >
> > serio1 being the keyboard here.
> >
> > Btw. is that "-n" really necessary? Had too look at the code to figure
> > out why it's not working :-)
> >
> > >
> > > X is X.org 6.8.1, keyboard is regular PS/2 keyboard, directly connected.
> >
> > Same here.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Lab tests show that use of micro$oft causes cancer in lab animals

2005-05-26 15:54:21

by Vojtech Pavlik

[permalink] [raw]
Subject: Re: 2.6.12-rc2: Compose key doesn't work

On Thu, May 26, 2005 at 11:45:09AM -0400, Wakko Warner wrote:
> Domen Puncer wrote:
> > Still true for 2.6.12-rc5. Should probably be fixed before final.
>
> I also have a problem with 2.6.12-rcX and ps/2 keyboard. I would say it's
> the same key we're talking about. It does not work at the console nor in X
> (showkey at the console does not see it). It works with a USB keyboard. My
> "compose" is mapped to the menu key beside the right windows key.
>
> I do wish they'd fix it, because I use this key (kinda like another ALT key)
> more than my compose key (again, the menu key, not the right win logo key)

This patch should fix it.

--
Vojtech Pavlik
SuSE Labs, SuSE CR


Attachments:
(No filename) (685.00 B)
atkbd-fix-scroll (809.00 B)
Download all attachments

2005-05-26 16:12:02

by Wakko Warner

[permalink] [raw]
Subject: Re: 2.6.12-rc2: Compose key doesn't work

Vojtech Pavlik wrote:
> On Thu, May 26, 2005 at 11:45:09AM -0400, Wakko Warner wrote:
> > I also have a problem with 2.6.12-rcX and ps/2 keyboard. I would say it's
> > the same key we're talking about. It does not work at the console nor in X
> > (showkey at the console does not see it). It works with a USB keyboard. My
> > "compose" is mapped to the menu key beside the right windows key.
> >
> > I do wish they'd fix it, because I use this key (kinda like another ALT key)
> > more than my compose key (again, the menu key, not the right win logo key)
>
> This patch should fix it.

Thanks, I'll try it out and let you know.

--
Lab tests show that use of micro$oft causes cancer in lab animals

2005-05-30 14:28:43

by Wakko Warner

[permalink] [raw]
Subject: Re: 2.6.12-rc2: Compose key doesn't work

Vojtech Pavlik wrote:
> On Thu, May 26, 2005 at 11:45:09AM -0400, Wakko Warner wrote:
> > I do wish they'd fix it, because I use this key (kinda like another ALT key)
> > more than my compose key (again, the menu key, not the right win logo key)
>
> This patch should fix it.

At work, I have a USB keyboard with 8 extra keys. Could something like this
be the cause of about 5 of those keys not working? (They worked under 2.4
perfectly)

> atkbd.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>
> diff -Nru a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> --- a/drivers/input/keyboard/atkbd.c 2005-05-03 15:23:34 +02:00
> +++ b/drivers/input/keyboard/atkbd.c 2005-05-03 15:23:34 +02:00
> @@ -171,9 +171,9 @@
> unsigned char set2;
> } atkbd_scroll_keys[] = {
> { ATKBD_SCR_1, 0xc5 },
> - { ATKBD_SCR_2, 0xa9 },
> - { ATKBD_SCR_4, 0xb6 },
> - { ATKBD_SCR_8, 0xa7 },
> + { ATKBD_SCR_2, 0x9d },
> + { ATKBD_SCR_4, 0xa4 },
> + { ATKBD_SCR_8, 0x9b },
> { ATKBD_SCR_CLICK, 0xe0 },
> { ATKBD_SCR_LEFT, 0xcb },
> { ATKBD_SCR_RIGHT, 0xd2 },

--
Lab tests show that use of micro$oft causes cancer in lab animals

2005-05-30 14:40:05

by Vojtech Pavlik

[permalink] [raw]
Subject: Re: 2.6.12-rc2: Compose key doesn't work

On Mon, May 30, 2005 at 10:25:15AM -0400, Wakko Warner wrote:
> Vojtech Pavlik wrote:
> > On Thu, May 26, 2005 at 11:45:09AM -0400, Wakko Warner wrote:
> > > I do wish they'd fix it, because I use this key (kinda like another ALT key)
> > > more than my compose key (again, the menu key, not the right win logo key)
> >
> > This patch should fix it.
>
> At work, I have a USB keyboard with 8 extra keys. Could something like this
> be the cause of about 5 of those keys not working? (They worked under 2.4
> perfectly)

No. This bug affects PS/2 (AT) keyboards only.

You can try 'evtest' to see if the keys are at least picked up by the
input subsystem. If not, then adding DEBUG to hid-input.h will tell
more. If yes, then they get lost between kernel and X.

--
Vojtech Pavlik
SuSE Labs, SuSE CR

2005-05-30 23:06:26

by Rene Herman

[permalink] [raw]
Subject: Re: 2.6.12-rc2: Compose key doesn't work

Vojtech Pavlik wrote:

> On Thu, May 26, 2005 at 11:45:09AM -0400, Wakko Warner wrote:

>>I also have a problem with 2.6.12-rcX and ps/2 keyboard. I would say it's
>>the same key we're talking about. It does not work at the console nor in X
>>(showkey at the console does not see it). It works with a USB keyboard. My
>>"compose" is mapped to the menu key beside the right windows key.
>>
>>I do wish they'd fix it, because I use this key (kinda like another ALT key)
>>more than my compose key (again, the menu key, not the right win logo key)
>
>
> This patch should fix it.
>
>
>
> ------------------------------------------------------------------------
>
> [email protected], 2005-04-04 15:37:45+02:00, [email protected]
> input: Fix fast scrolling scancodes in atkbd.c

ACK, thanks.

Rene.