2005-05-30 20:56:53

by Adrian Bunk

Subject: [-mm patch] net/ieee80211/: remove pci.h #include's

I was wondering why editing pci.h triggered the rebuild of three files
under net/, and as far as I can see, there's no reason for these three
files to #include pci.h .

Signed-off-by: Adrian Bunk <[email protected]>

---

This patch was already sent on:
- 1 May 2005

net/ieee80211/ieee80211_module.c | 1 -
net/ieee80211/ieee80211_rx.c | 1 -
net/ieee80211/ieee80211_tx.c | 1 -
3 files changed, 3 deletions(-)

--- linux-2.6.12-rc3-mm1-full/net/ieee80211/ieee80211_module.c.old 2005-04-30 23:23:14.000000000 +0200
+++ linux-2.6.12-rc3-mm1-full/net/ieee80211/ieee80211_module.c 2005-04-30 23:23:18.000000000 +0200
@@ -40,7 +40,6 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/netdevice.h>
-#include <linux/pci.h>
#include <linux/proc_fs.h>
#include <linux/skbuff.h>
#include <linux/slab.h>
--- linux-2.6.12-rc3-mm1-full/net/ieee80211/ieee80211_tx.c.old 2005-04-30 23:23:25.000000000 +0200
+++ linux-2.6.12-rc3-mm1-full/net/ieee80211/ieee80211_tx.c 2005-04-30 23:23:32.000000000 +0200
@@ -33,7 +33,6 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/netdevice.h>
-#include <linux/pci.h>
#include <linux/proc_fs.h>
#include <linux/skbuff.h>
#include <linux/slab.h>
--- linux-2.6.12-rc3-mm1-full/net/ieee80211/ieee80211_rx.c.old 2005-04-30 23:23:42.000000000 +0200
+++ linux-2.6.12-rc3-mm1-full/net/ieee80211/ieee80211_rx.c 2005-04-30 23:23:46.000000000 +0200
@@ -23,7 +23,6 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/netdevice.h>
-#include <linux/pci.h>
#include <linux/proc_fs.h>
#include <linux/skbuff.h>
#include <linux/slab.h>

2005-05-31 01:26:50

by Jouni Malinen

Subject: Re: [-mm patch] net/ieee80211/: remove pci.h #include's

On Mon, May 30, 2005 at 10:56:34PM +0200, Adrian Bunk wrote:

> I was wondering why editing pci.h triggered the rebuild of three files
> under net/, and as far as I can see, there's no reason for these three
> files to #include pci.h .

> net/ieee80211/ieee80211_module.c | 1 -
> net/ieee80211/ieee80211_rx.c | 1 -
> net/ieee80211/ieee80211_tx.c | 1 -

I don't know where these came from since Host AP driver does not include
linux/pci.h into the files doing generic IEEE 802.11 processing. Anyway,
I have nothing against removing these include lines.

--
Jouni Malinen PGP id EFC895FA