2005-09-03 01:28:40

by Adrian Bunk

[permalink] [raw]
Subject: [2.6 patch] net/netfilter/nfnetlink*: make functions static

This patch makes needlessly global functions static.


Signed-off-by: Adrian Bunk <[email protected]>

---

net/netfilter/nfnetlink.c | 4 ++--
net/netfilter/nfnetlink_queue.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)

--- linux-2.6.13-mm1-full/net/netfilter/nfnetlink.c.old 2005-09-03 02:26:18.000000000 +0200
+++ linux-2.6.13-mm1-full/net/netfilter/nfnetlink.c 2005-09-03 02:27:21.000000000 +0200
@@ -344,14 +344,14 @@
} while(nfnl && nfnl->sk_receive_queue.qlen);
}

-void __exit nfnetlink_exit(void)
+static void __exit nfnetlink_exit(void)
{
printk("Removing netfilter NETLINK layer.\n");
sock_release(nfnl->sk_socket);
return;
}

-int __init nfnetlink_init(void)
+static int __init nfnetlink_init(void)
{
printk("Netfilter messages via NETLINK v%s.\n", nfversion);

--- linux-2.6.13-mm1-full/net/netfilter/nfnetlink_queue.c.old 2005-09-03 02:26:55.000000000 +0200
+++ linux-2.6.13-mm1-full/net/netfilter/nfnetlink_queue.c 2005-09-03 02:27:06.000000000 +0200
@@ -76,7 +76,7 @@

static DEFINE_RWLOCK(instances_lock);

-u_int64_t htonll(u_int64_t in)
+static u_int64_t htonll(u_int64_t in)
{
u_int64_t out;
int i;


2005-09-03 08:13:49

by Harald Welte

[permalink] [raw]
Subject: Re: [netfilter-core] [2.6 patch] net/netfilter/nfnetlink*: make functions static

On Sat, Sep 03, 2005 at 03:28:29AM +0200, Adrian Bunk wrote:
> This patch makes needlessly global functions static.

Thanks for your patch. I'll merge it with my local changes (it clashes,
since the "htonll" implementation was removed) and submit it via davem
later today.

--
- Harald Welte <[email protected]> http://netfilter.org/
============================================================================
"Fragmentation is like classful addressing -- an interesting early
architectural error that shows how much experimentation was going
on while IP was being designed." -- Paul Vixie


Attachments:
(No filename) (640.00 B)
(No filename) (189.00 B)
Download all attachments