I played with a daisy chain device that is not ieee1284 compliant
and found buffer overflow and failure to open daisy chain devices.
While fixing it I found also a number of other problems also affecting
proper ieee1284 devices.
This is a collection of the changes I have made. They have been through
linux-parport mailing list already in January and they have been modified
according to comments.
--
[email protected] wrote:
>
> I played with a daisy chain device that is not ieee1284 compliant
> and found buffer overflow and failure to open daisy chain devices.
> While fixing it I found also a number of other problems also affecting
> proper ieee1284 devices.
>
> This is a collection of the changes I have made. They have been through
> linux-parport mailing list already in January and they have been modified
> according to comments.
umm, OK. parport patches worry me because nobody seems to understand the
code any more. We'll see.
You just sent ten patches, all with the same name. This causes me grief
(See http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt, section 2a).
I now need to invent names for your patches, and if I later refer to one of
them you won't know which one I'm talking about. Oh well.
On 9/7/05, Andrew Morton <[email protected]> wrote:
> [email protected] wrote:
> > This is a collection of the changes I have made. They have been through
> > linux-parport mailing list already in January and they have been modified
> > according to comments.
>
> umm, OK. parport patches worry me because nobody seems to understand the
> code any more. We'll see.
Thanks. I'm worried too.
>From the responses in linux-parport I gathered some of the bugs are
there because people have not used the code. Therefore I also
considered removing it would be good, but was afraid to do so.
Also there are drivers that would have use for it, but they just are
currently implemented either by just reserving the whole parport and
then doing their daisy chain magic.
> You just sent ten patches, all with the same name. This causes me grief
> (See http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt, section 2a).
I used "quilt mail" to send those patches and it seems it requires
some additional trick I did not notice to make the patches have
different subjects. I had read the document you referred to but missed
that part. I also had picked somewhere the idea that having same
subject helped group the patches.
> I now need to invent names for your patches, and if I later refer to one of
> them you won't know which one I'm talking about. Oh well.
I can also resend the patches to you. I understand you have a lot to
do already and I want to be of help, not burden.
Marko Kohtala <[email protected]> wrote:
>
> > You just sent ten patches, all with the same name. This causes me grief
> > (See http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt, section 2a).
>
> I used "quilt mail" to send those patches and it seems it requires
> some additional trick I did not notice to make the patches have
> different subjects.
I complained to the quilt guys about that and they did make a move to fix
it, but I recall not being very happy with the proposal. Anyway, make sure
you have the latest version and check the documentation - it's in there
somewhere.
As a last resort, put the title into the first line of the changelog and
I'll cut-n-paste it.
> that part. I also had picked somewhere the idea that having same
> subject helped group the patches.
>
> > I now need to invent names for your patches, and if I later refer to one of
> > them you won't know which one I'm talking about. Oh well.
>
> I can also resend the patches to you. I understand you have a lot to
> do already and I want to be of help, not burden.
Is OK, I'll work something out.
On Wednesday 07 September 2005 06:50, Andrew Morton wrote:
> Marko Kohtala <[email protected]> wrote:
> >
> > > You just sent ten patches, all with the same name. This causes me grief
> > > (See http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt, section 2a).
> >
> > I used "quilt mail" to send those patches and it seems it requires
> > some additional trick I did not notice to make the patches have
> > different subjects.
>
> I complained to the quilt guys about that and they did make a move to fix
> it, but I recall not being very happy with the proposal. Anyway, make sure
> you have the latest version and check the documentation - it's in there
> somewhere.
>
> As a last resort, put the title into the first line of the changelog and
> I'll cut-n-paste it.
>
I have the following in my .quiltrc
quilt_mail_patch_filter() {
local x=$(cat)
echo "$x" \
| sed -n \
-e 's/^\(To\|Cc\):/Recipient-\1:/ip' \
-e 's/^Subject:/Replace-Subject:/p' \
-e '/^\*\*\*\|---/q'
echo
# Discard the patch header, and pass on the rest
echo "$x" | awk '
!seen_from && (/^From: /) { print $0 "\n" ; seen_from = 1 }
!in_body && (/^[-A-Za-z]+:/) { next }
!in_body && (/^$/) { in_body = 1 ; next }
{ print }
'
}
And I have my patches in the following form:
Subject: mail subject
From: <someone if not I, git uses it>
<area (Usually Input)>: Short patch description
Decsription
Signed-off-by: X XX
---
<patch>
Then quilt mail command seems to do the right thing.
--
Dmitry