2005-09-08 05:40:54

by KUROSAWA Takahiro

Subject: [PATCH 1/5][BUG] SUBCPUSETS: fix for cpusets minor problem

This patch fixes minor problem that the CPUSETS have when files
in the cpuset filesystem are read after lseek()-ed beyond the EOF.

Signed-off-by: KUROSAWA Takahiro <[email protected]>

--- from-0001/kernel/cpuset.c
+++ to-work/kernel/cpuset.c 2005-09-05 20:26:18.075772762 +0900
@@ -984,6 +984,10 @@ static ssize_t cpuset_common_file_read(s
*s++ = '\n';
*s = '\0';

+ /* Do nothing if *ppos is at the eof or beyond the eof. */
+ if (s - page <= *ppos)
+ return 0;
+
start = page + *ppos;
n = s - start;
retval = n - copy_to_user(buf, start, min(n, nbytes));

2005-09-08 11:18:48

by Robin Holt

Subject: Re: [PATCH 1/5][BUG] SUBCPUSETS: fix for cpusets minor problem

On Thu, Sep 08, 2005 at 02:40:53PM +0900, KUROSAWA Takahiro wrote:
> This patch fixes minor problem that the CPUSETS have when files
> in the cpuset filesystem are read after lseek()-ed beyond the EOF.
>
> Signed-off-by: KUROSAWA Takahiro <[email protected]>
>
> --- from-0001/kernel/cpuset.c
> +++ to-work/kernel/cpuset.c 2005-09-05 20:26:18.075772762 +0900
> @@ -984,6 +984,10 @@ static ssize_t cpuset_common_file_read(s
> *s++ = '\n';
> *s = '\0';
>
> + /* Do nothing if *ppos is at the eof or beyond the eof. */
> + if (s - page <= *ppos)
> + return 0;
> +
> start = page + *ppos;
> n = s - start;
> retval = n - copy_to_user(buf, start, min(n, nbytes));


Paul, I think this should go in regardless of the other subcpuset
changes being proposed. What do you think?

Robin

2005-09-08 11:26:13

by Robin Holt

Subject: Re: [PATCH 1/5][BUG] SUBCPUSETS: fix for cpusets minor problem

On Thu, Sep 08, 2005 at 06:17:31AM -0500, Robin Holt wrote:
> On Thu, Sep 08, 2005 at 02:40:53PM +0900, KUROSAWA Takahiro wrote:
> > This patch fixes minor problem that the CPUSETS have when files
> > in the cpuset filesystem are read after lseek()-ed beyond the EOF.
> >
> > Signed-off-by: KUROSAWA Takahiro <[email protected]>
> >
> > --- from-0001/kernel/cpuset.c
> > +++ to-work/kernel/cpuset.c 2005-09-05 20:26:18.075772762 +0900
> > @@ -984,6 +984,10 @@ static ssize_t cpuset_common_file_read(s
> > *s++ = '\n';
> > *s = '\0';
> >
> > + /* Do nothing if *ppos is at the eof or beyond the eof. */
> > + if (s - page <= *ppos)
> > + return 0;
> > +
> > start = page + *ppos;
> > n = s - start;
> > retval = n - copy_to_user(buf, start, min(n, nbytes));
>
>
> Paul, I think this should go in regardless of the other subcpuset
> changes being proposed. What do you think?


Oops, didn't see you had already sent it along. Sorry, Robin

2005-09-08 11:58:16

by Paul Jackson

Subject: Re: [PATCH 1/5][BUG] SUBCPUSETS: fix for cpusets minor problem

Robin wrote:
> Oops, didn't see you had already sent it along.

Looks like you, me, Takahiro-san and Andrew are all in agreement
on sending this Patch 1/5 along.

Excellent.

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <[email protected]> 1.925.600.0401