Signed-off-by: Luben Tuikov <[email protected]>
diff -X linux-2.6.13/Documentation/dontdiff -Naur linux-2.6.13-orig/drivers/scsi/aic94xx/Makefile linux-2.6.13/drivers/scsi/aic94xx/Makefile
--- linux-2.6.13-orig/drivers/scsi/aic94xx/Makefile 1969-12-31 19:00:00.000000000 -0500
+++ linux-2.6.13/drivers/scsi/aic94xx/Makefile 2005-09-09 11:23:01.000000000 -0400
@@ -0,0 +1,46 @@
+#
+# Makefile for Adaptec aic94xx SAS/SATA driver.
+#
+# Copyright (C) 2005 Adaptec, Inc. All rights reserved.
+# Copyright (C) 2005 Luben Tuikov <[email protected]>
+#
+# This file is licensed under GPLv2.
+#
+# This file is part of the the aic94xx driver.
+#
+# The aic94xx driver is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; version 2 of the
+# License.
+#
+# The aic94xx driver is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+# General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with the aic94xx driver; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# $Id: //depot/aic94xx/Makefile#34 $
+#
+
+CHECK = sparse -Wbitwise
+
+ifeq ($(CONFIG_AIC94XX_DEBUG),y)
+ EXTRA_CFLAGS += -DASD_DEBUG -DASD_ENTER_EXIT -g
+endif
+
+clean-files += *~
+
+obj-$(CONFIG_SCSI_AIC94XX) += aic94xx.o
+aic94xx-y += aic94xx_init.o \
+ aic94xx_hwi.o \
+ aic94xx_reg.o \
+ aic94xx_sds.o \
+ aic94xx_seq.o \
+ aic94xx_dump.o \
+ aic94xx_scb.o \
+ aic94xx_dev.o \
+ aic94xx_tmf.o \
+ aic94xx_task.o
A single file per patch is not really a patch split up. Patches should
stand on their own, leaving the tree in a compilable functioning state
during each step.
-ben
Hi Ben,
I think I mentioned this in the Announcement 0/2:
http://www.geocities.com/ltuikov/
I'll soon move this to an Adaptec site.
Luben
On 09/09/05 15:35, Benjamin LaHaise wrote:
> A single file per patch is not really a patch split up. Patches should
> stand on their own, leaving the tree in a compilable functioning state
> during each step.
>
> -ben
>
On Fri, Sep 09, 2005 at 03:32:05PM -0400, Luben Tuikov wrote:
> --- linux-2.6.13-orig/drivers/scsi/aic94xx/Makefile
> +++ linux-2.6.13/drivers/scsi/aic94xx/Makefile
> +CHECK = sparse -Wbitwise
make C=1 CHECK="sparse -Wbitwise"
or
make C=1
> +clean-files += *~
Don't override what other people want.
On Fri, Sep 09, 2005 at 03:35:41PM -0400, Benjamin LaHaise wrote:
> A single file per patch is not really a patch split up. Patches should
> stand on their own, leaving the tree in a compilable functioning state
> during each step.
Agreed, though for new drivers, this appears to be one way to get new
code past mailing list size filters, making it easier for the linux-scsi
audience to review the code. The alternative is posting a link, which
cuts down on mailing list spew, but also I bet cuts down on review.
Jeff
On 09/09/05 16:18, Alexey Dobriyan wrote:
> On Fri, Sep 09, 2005 at 03:32:05PM -0400, Luben Tuikov wrote:
>
>>--- linux-2.6.13-orig/drivers/scsi/aic94xx/Makefile
>>+++ linux-2.6.13/drivers/scsi/aic94xx/Makefile
>
>
>>+CHECK = sparse -Wbitwise
>
>
> make C=1 CHECK="sparse -Wbitwise"
> or
> make C=1
>
>
>>+clean-files += *~
>
>
> Don't override what other people want.
Ok, will do.
Luben
On Sat, Sep 10, 2005 at 12:18:34AM +0400, Alexey Dobriyan wrote:
> On Fri, Sep 09, 2005 at 03:32:05PM -0400, Luben Tuikov wrote:
> > --- linux-2.6.13-orig/drivers/scsi/aic94xx/Makefile
> > +++ linux-2.6.13/drivers/scsi/aic94xx/Makefile
>
> > +CHECK = sparse -Wbitwise
>
> make C=1 CHECK="sparse -Wbitwise"
> or
> make C=1
Or patch below and use make C=1 CF=-Wbitwise...
Allows to add to sparse arguments without mutilating makefiles - just
pass CF=<arguments> and they will be added to CHECKFLAGS.
Signed-off-by: Al Viro <[email protected]>
----
diff -urN RC13-git7-kconfig/Makefile RC13-git7-CHECKFLAGS/Makefile
--- RC13-git7-kconfig/Makefile 2005-09-07 13:54:44.000000000 -0400
+++ RC13-git7-CHECKFLAGS/Makefile 2005-09-07 13:54:46.000000000 -0400
@@ -333,7 +333,7 @@
PERL = perl
CHECK = sparse
-CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__
+CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ $(CF)
MODFLAGS = -DMODULE
CFLAGS_MODULE = $(MODFLAGS)
AFLAGS_MODULE = $(MODFLAGS)
On Fri, Sep 09, 2005 at 09:14:35PM +0100, [email protected] wrote:
> On Sat, Sep 10, 2005 at 12:18:34AM +0400, Alexey Dobriyan wrote:
> > On Fri, Sep 09, 2005 at 03:32:05PM -0400, Luben Tuikov wrote:
> > > --- linux-2.6.13-orig/drivers/scsi/aic94xx/Makefile
> > > +++ linux-2.6.13/drivers/scsi/aic94xx/Makefile
> >
> > > +CHECK = sparse -Wbitwise
> >
> > make C=1 CHECK="sparse -Wbitwise"
> > or
> > make C=1
> Or patch below and use make C=1 CF=-Wbitwise...
>
> Allows to add to sparse arguments without mutilating makefiles - just
> pass CF=<arguments> and they will be added to CHECKFLAGS.
Applied - thanks.
Sam