Dmitry Torokhov <[email protected]> wrote:
>
> Input: convert drivers/iusb/input to dynamic input_dev allocation
The absfuzz initialisation in kbtab_probe() got lost.
On Thursday 15 September 2005 22:53, Andrew Morton wrote:
> Dmitry Torokhov <[email protected]> wrote:
> >
> > Input: convert drivers/iusb/input to dynamic input_dev allocation
>
> The absfuzz initialisation in kbtab_probe() got lost.
>
Looks fine here:
+ input_set_abs_params(input_dev, ABS_X, 0, 0x2000, 4, 0);
+ input_set_abs_params(input_dev, ABS_X, 0, 0x1750, 4, 0);
^^^
Is there something in your tree that not in Linus's yet?
--
Dmitry
Dmitry Torokhov <[email protected]> wrote:
>
> On Thursday 15 September 2005 22:53, Andrew Morton wrote:
> > Dmitry Torokhov <[email protected]> wrote:
> > >
> > > Input: convert drivers/iusb/input to dynamic input_dev allocation
> >
> > The absfuzz initialisation in kbtab_probe() got lost.
> >
>
> Looks fine here:
>
> + input_set_abs_params(input_dev, ABS_X, 0, 0x2000, 4, 0);
> + input_set_abs_params(input_dev, ABS_X, 0, 0x1750, 4, 0);
> ^^^
Oh. You mean they replace these?
- kbtab->dev.absfuzz[ABS_X] = 4;
- kbtab->dev.absfuzz[ABS_Y] = 4;
Not a step forward in readability?
>
> Is there something in your tree that not in Linus's yet?
>
Yeah, some stuff, that's why I noticed.
On Thursday 15 September 2005 23:18, Andrew Morton wrote:
> Dmitry Torokhov <[email protected]> wrote:
> >
> > On Thursday 15 September 2005 22:53, Andrew Morton wrote:
> > > Dmitry Torokhov <[email protected]> wrote:
> > > >
> > > > Input: convert drivers/iusb/input to dynamic input_dev allocation
> > >
> > > The absfuzz initialisation in kbtab_probe() got lost.
> > >
> >
> > Looks fine here:
> >
> > + input_set_abs_params(input_dev, ABS_X, 0, 0x2000, 4, 0);
> > + input_set_abs_params(input_dev, ABS_X, 0, 0x1750, 4, 0);
> > ^^^
>
> Oh. You mean they replace these?
>
> - kbtab->dev.absfuzz[ABS_X] = 4;
> - kbtab->dev.absfuzz[ABS_Y] = 4;
>
> Not a step forward in readability?
>
Depends... It's much more compact so quite often you can see entire
device specification on one screen which is nice IMHO. Just remeber
"min, max, fuzz, flat" ;)
--
Dmitry