2005-09-30 02:22:52

by Chris Wright

[permalink] [raw]
Subject: [PATCH 03/10] [PATCH] fix IPv6 per-socket multicast filtering in exact-match case

-stable review patch. If anyone has any objections, please let us know.
------------------

per-socket multicast filters were not being applied to all sockets
in the case of an exact-match bound address, due to an over-exuberant
"return" in the look-up code. Fix below. IPv4 does not have this problem.

Thanks to Hoerdt Mickael for reporting the bug.

Signed-off-by: David L Stevens <[email protected]>
Signed-off-by: Chris Wright <[email protected]>
---
net/ipv6/udp.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

Index: linux-2.6.13.y/net/ipv6/udp.c
===================================================================
--- linux-2.6.13.y.orig/net/ipv6/udp.c
+++ linux-2.6.13.y/net/ipv6/udp.c
@@ -404,9 +404,8 @@ static struct sock *udp_v6_mcast_next(st
continue;

if (!ipv6_addr_any(&np->rcv_saddr)) {
- if (ipv6_addr_equal(&np->rcv_saddr, loc_addr))
- return s;
- continue;
+ if (!ipv6_addr_equal(&np->rcv_saddr, loc_addr))
+ continue;
}
if(!inet6_mc_check(s, loc_addr, rmt_addr))
continue;

--