Hi,
Here is a patch that enables the ATA133 mode for the SiS965 southbridge
in the SiS5513 driver.
Thanks,
Aurelien
Signed-off-by: Aurelien Jarno <[email protected]>
--- linux-2.6.14-rc3-git4.orig/drivers/ide/pci/sis5513.c 2005-08-29 01:41:01.000000000 +0200
+++ linux-2.6.14-rc3-git4/drivers/ide/pci/sis5513.c 2005-10-05 22:12:30.000000000 +0200
@@ -87,6 +87,7 @@
u8 chipset_family;
u8 flags;
} SiSHostChipInfo[] = {
+ { "SiS965", PCI_DEVICE_ID_SI_965, ATA_133 },
{ "SiS745", PCI_DEVICE_ID_SI_745, ATA_100 },
{ "SiS735", PCI_DEVICE_ID_SI_735, ATA_100 },
{ "SiS733", PCI_DEVICE_ID_SI_733, ATA_100 },
--- linux-2.6.14-rc3-git4.orig/include/linux/pci_ids.h 2005-10-05 22:08:49.000000000 +0200
+++ linux-2.6.14-rc3-git4/include/linux/pci_ids.h 2005-10-05 22:13:35.000000000 +0200
@@ -672,6 +672,7 @@
#define PCI_DEVICE_ID_SI_961 0x0961
#define PCI_DEVICE_ID_SI_962 0x0962
#define PCI_DEVICE_ID_SI_963 0x0963
+#define PCI_DEVICE_ID_SI_965 0x0965
#define PCI_DEVICE_ID_SI_5107 0x5107
#define PCI_DEVICE_ID_SI_5300 0x5300
#define PCI_DEVICE_ID_SI_5511 0x5511
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' [email protected] | [email protected]
`- people.debian.org/~aurel32 | http://www.aurel32.net
Hi,
On 10/5/05, Aurelien Jarno <[email protected]> wrote:
> Hi,
>
> Here is a patch that enables the ATA133 mode for the SiS965 southbridge
> in the SiS5513 driver.
The patch for SIS965(L) support is already in -mm tree:
http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.14-rc2/2.6.14-rc2-mm2/broken-out/sis5513-support-sis-965l.patch
Have you tried it?
Thanks,
Bartlomiej
> --- linux-2.6.14-rc3-git4.orig/drivers/ide/pci/sis5513.c 2005-08-29 01:41:01.000000000 +0200
> +++ linux-2.6.14-rc3-git4/drivers/ide/pci/sis5513.c 2005-10-05 22:12:30.000000000 +0200
> @@ -87,6 +87,7 @@
> u8 chipset_family;
> u8 flags;
> } SiSHostChipInfo[] = {
> + { "SiS965", PCI_DEVICE_ID_SI_965, ATA_133 },
> { "SiS745", PCI_DEVICE_ID_SI_745, ATA_100 },
> { "SiS735", PCI_DEVICE_ID_SI_735, ATA_100 },
> { "SiS733", PCI_DEVICE_ID_SI_733, ATA_100 },
> --- linux-2.6.14-rc3-git4.orig/include/linux/pci_ids.h 2005-10-05 22:08:49.000000000 +0200
> +++ linux-2.6.14-rc3-git4/include/linux/pci_ids.h 2005-10-05 22:13:35.000000000 +0200
> @@ -672,6 +672,7 @@
> #define PCI_DEVICE_ID_SI_961 0x0961
> #define PCI_DEVICE_ID_SI_962 0x0962
> #define PCI_DEVICE_ID_SI_963 0x0963
> +#define PCI_DEVICE_ID_SI_965 0x0965
> #define PCI_DEVICE_ID_SI_5107 0x5107
> #define PCI_DEVICE_ID_SI_5300 0x5300
> #define PCI_DEVICE_ID_SI_5511 0x5511
On Thu, Oct 06, 2005 at 11:40:15AM +0200, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> On 10/5/05, Aurelien Jarno <[email protected]> wrote:
> > Hi,
> >
> > Here is a patch that enables the ATA133 mode for the SiS965 southbridge
> > in the SiS5513 driver.
>
> The patch for SIS965(L) support is already in -mm tree:
> http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.14-rc2/2.6.14-rc2-mm2/broken-out/sis5513-support-sis-965l.patch
>
Oops, I forget to look at the -mm tree for this driver. You're right, it
works, and it seems the patch is cleaner than mine. So please ignore my
patch.
Thanks,
Aurelien
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' [email protected] | [email protected]
`- people.debian.org/~aurel32 | http://www.aurel32.net
Aurelien Jarno wrote:
>On Thu, Oct 06, 2005 at 11:40:15AM +0200, Bartlomiej Zolnierkiewicz wrote:
>
>
>>Hi,
>>
>>On 10/5/05, Aurelien Jarno <[email protected]> wrote:
>>
>>
>>>Hi,
>>>
>>>Here is a patch that enables the ATA133 mode for the SiS965 southbridge
>>>in the SiS5513 driver.
>>>
>>>
>>The patch for SIS965(L) support is already in -mm tree:
>>http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.14-rc2/2.6.14-rc2-mm2/broken-out/sis5513-support-sis-965l.patch
>>
>>
>>
>
>Oops, I forget to look at the -mm tree for this driver. You're right, it
>works, and it seems the patch is cleaner than mine. So please ignore my
>patch.
>
>Thanks,
>Aurelien
>
>
>
It appears to me that this patch will try and apply itself to the real
SIS_180 which has the same true_id of 0x180. Can someone tell me what
will happen then?
--
KT133 MB, CPU @2400MHz (24x100): SIS755 MB CPU @2330MHz (10x233)
Need good help? Provide all system info with question.
My server http://wesnewell.no-ip.com/cpu.php
Verizon server http://mysite.verizon.net/res0exft/cpu.htm
On Fri, Oct 07, 2005 at 11:36:46AM -0500, Wes Newell wrote:
> It appears to me that this patch will try and apply itself to the real
> SIS_180 which has the same true_id of 0x180. Can someone tell me what
> will happen then?
Indeed, I've tried Aurelien's patch and it works fine for me (on an asus
k8s-mx motherboard). Going back over the reasons for the patch that is
in -mm that I submitted, which was a rework of
a patch that Arnaud Patard/Uwe Koziolek sent to linux-ide, it seems that the
thinking was that complex probing and/or configuration was required for
this chipset. I don't have any specs to work from, and am not the expert
in any case, but it would seem that this is not necessary, and
just doing a standard detect of the southbridge id is fine.
Unless anyone has stronger evidence/experience, it would seem that the
simplest/cleanest solution is an update to SiSHostChipInfo[], as in Aurelien's
patch.
This patch has conflict with sata_sis driver. They both register this
id 0x0180. But pci ide driver is loaded first. So if you have sata
drive connected as root, dang, you'll get kernel panic. I had this
problem with 2.6.14_rc4-mm1. Simply delete the third line from
structure sis5513_pci_tbl resolved it.
I know it's just a work around.
Can somebody tell me how to track file history under mm- tree?
On 10/7/05, Wes Newell <[email protected]> wrote:
> Aurelien Jarno wrote:
>
> >On Thu, Oct 06, 2005 at 11:40:15AM +0200, Bartlomiej Zolnierkiewicz wrote:
> >
> >
> >>Hi,
> >>
> >>On 10/5/05, Aurelien Jarno <[email protected]> wrote:
> >>
> >>
> >>>Hi,
> >>>
> >>>Here is a patch that enables the ATA133 mode for the SiS965 southbridge
> >>>in the SiS5513 driver.
> >>>
> >>>
> >>The patch for SIS965(L) support is already in -mm tree:
> >>http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.14-rc2/2.6.14-rc2-mm2/broken-out/sis5513-support-sis-965l.patch
> >>
> >>
> >>
> >
> >Oops, I forget to look at the -mm tree for this driver. You're right, it
> >works, and it seems the patch is cleaner than mine. So please ignore my
> >patch.
> >
> >Thanks,
> >Aurelien
> >
> >
> >
> It appears to me that this patch will try and apply itself to the real
> SIS_180 which has the same true_id of 0x180. Can someone tell me what
> will happen then?
>
>
> --
> KT133 MB, CPU @2400MHz (24x100): SIS755 MB CPU @2330MHz (10x233)
> Need good help? Provide all system info with question.
> My server http://wesnewell.no-ip.com/cpu.php
> Verizon server http://mysite.verizon.net/res0exft/cpu.htm
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
wsong <[email protected]> :
> This patch has conflict with sata_sis driver. They both register this
> id 0x0180. But pci ide driver is loaded first. So if you have sata
> drive connected as root, dang, you'll get kernel panic. I had this
> problem with 2.6.14_rc4-mm1. Simply delete the third line from
> structure sis5513_pci_tbl resolved it.
>
> I know it's just a work around.
The lspci I have received for a k8s-mx exhibit a 5513 whose PCI ID is
already correctly set. If the ID masking and register remapping is not
really relevant on a 180, the code below could be enough. If it is wrong,
it may be better to check the availability of a good backup system before
using it.
Some features documentation suggest that the 760 and the 755 should
mostly go along with the same southbridge.
Signed-off-by: Francois Romieu <[email protected]>
diff --git a/drivers/ide/pci/sis5513.c b/drivers/ide/pci/sis5513.c
--- a/drivers/ide/pci/sis5513.c
+++ b/drivers/ide/pci/sis5513.c
@@ -20,6 +20,7 @@
* ATA16/33 support from specs
* ATA133 support for SiS961/962 by L.C. Chang <[email protected]>
* ATA133 961/962/963 fixes by Vojtech Pavlik <[email protected]>
+ * ATA133 965 hack by Ueimor <[email protected]>
*
* Documentation:
* SiS chipset documentation available under NDA to companies only
@@ -87,6 +88,9 @@ static const struct {
u8 chipset_family;
u8 flags;
} SiSHostChipInfo[] = {
+ { "SiS760", PCI_DEVICE_ID_SI_760, ATA_133 },
+ { "SiS755", PCI_DEVICE_ID_SI_755, ATA_133 },
+
{ "SiS745", PCI_DEVICE_ID_SI_745, ATA_100 },
{ "SiS735", PCI_DEVICE_ID_SI_735, ATA_100 },
{ "SiS733", PCI_DEVICE_ID_SI_733, ATA_100 },