2005-10-11 21:19:33

by Jesper Juhl

[permalink] [raw]
Subject: [PATCH] small Kconfig help text correction for CONFIG_FRAME_POINTER

Fix-up the CONFIG_FRAME_POINTER help text language a bit.

Signed-off-by: Jesper Juhl <[email protected]>
---

"on some architectures or you use external debuggers"
doesn't sound too good
"on some architectures or if you use external debuggers"
is better.

lib/Kconfig.debug | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.14-rc4-orig/lib/Kconfig.debug 2005-10-11 22:41:32.000000000 +0200
+++ linux-2.6.14-rc4/lib/Kconfig.debug 2005-10-11 23:16:30.000000000 +0200
@@ -174,7 +174,7 @@
default y if DEBUG_INFO && UML
help
If you say Y here the resulting kernel image will be slightly larger
- and slower, but it might give very useful debugging information
- on some architectures or you use external debuggers.
+ and slower, but it might give very useful debugging information on
+ some architectures or if you use external debuggers.
If you don't debug the kernel, you can say N.




2005-10-12 01:25:37

by Qi Yong

[permalink] [raw]
Subject: Re: [PATCH] small Kconfig help text correction for CONFIG_FRAME_POINTER

On Tue, Oct 11, 2005 at 11:22:21PM +0200, Jesper Juhl wrote:
> Fix-up the CONFIG_FRAME_POINTER help text language a bit.
>
> Signed-off-by: Jesper Juhl <[email protected]>
> ---
>
> "on some architectures or you use external debuggers"
> doesn't sound too good
> "on some architectures or if you use external debuggers"
> is better.


Why bother anyway since the original is brief and neat. (yours could be s/if/when/ even)


Coywolf

>
> lib/Kconfig.debug | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.14-rc4-orig/lib/Kconfig.debug 2005-10-11 22:41:32.000000000 +0200
> +++ linux-2.6.14-rc4/lib/Kconfig.debug 2005-10-11 23:16:30.000000000 +0200
> @@ -174,7 +174,7 @@
> default y if DEBUG_INFO && UML
> help
> If you say Y here the resulting kernel image will be slightly larger
> - and slower, but it might give very useful debugging information
> - on some architectures or you use external debuggers.
> + and slower, but it might give very useful debugging information on
> + some architectures or if you use external debuggers.
> If you don't debug the kernel, you can say N.
>
>
>
> -

2005-10-12 01:50:48

by Felix Oxley

[permalink] [raw]
Subject: Re: [PATCH] small Kconfig help text correction for CONFIG_FRAME_POINTER

On Wednesday 12 October 2005 02:25, Coywolf Qi Hunt wrote:
> On Tue, Oct 11, 2005 at 11:22:21PM +0200, Jesper Juhl wrote:
>
> Why bother anyway since the original is brief and neat. (yours could be
> s/if/when/ even)

I would definitely agree with Jesper that the current version needs changing.
However, I don't know technically whether it means:

a) you will need an external debugger to get this information
b) this information will be available in the log (etc) and ALSO via an
external debugger

regards,
Felix

>
> > If you say Y here the resulting kernel image will be slightly larger
> > - and slower, but it might give very useful debugging information
> > - on some architectures or you use external debuggers.
> > + and slower, but it might give very useful debugging information on
> > + some architectures or if you use external debuggers.
> > If you don't debug the kernel, you can say N.

2005-10-12 21:35:51

by Jesper Juhl

[permalink] [raw]
Subject: Re: [PATCH] small Kconfig help text correction for CONFIG_FRAME_POINTER

On 10/12/05, Coywolf Qi Hunt <[email protected]> wrote:
> On Tue, Oct 11, 2005 at 11:22:21PM +0200, Jesper Juhl wrote:
> > Fix-up the CONFIG_FRAME_POINTER help text language a bit.
> >
> > Signed-off-by: Jesper Juhl <[email protected]>
> > ---
> >
> > "on some architectures or you use external debuggers"
> > doesn't sound too good
> > "on some architectures or if you use external debuggers"
> > is better.
>
>
> Why bother anyway since the original is brief and neat. (yours could be s/if/when/ even)
>

We can argue the exact wording (using "when" is probably better, I
agree), but the current text is just not proper english.


--
Jesper Juhl <[email protected]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html