2005-10-16 17:41:56

by Suzanne Wood

[permalink] [raw]
Subject: drivers/net/r8169 comment

Looking at the sourcecode in rtl8169_down()
of drivers/net/r8169.c and the comparable code in
sis190_down() of drivers/net/sis190_down()
supports removing that comment as you suggest here.

I'd used this comparison to resolve an RCU question,
so I'm not the person to address this.
Thank you for the clarification.

----- Original Message -----
From: "Francois Romieu" <[email protected]>
Sent: Saturday, October 15, 2005 4:24 AM
Subject: Re: [RFC][PATCH] rcu in drivers/net/hamradio

>> synchronize_sched() is called in drivers/net/sis190.c and
>> r8169.c with FIXME comment about synchronize_irq()
>
> Same author for both. The code (driver specific) can be issued from
> userspace and it needs to wait for running hard_start_xmit to
> complete. Afaik synchronize_irq() is not adequate and the FIXME
> should go.
>
> --
> Ueimor
>