2005-10-26 10:06:27

by Al Viro

Subject: [PATCH] fix alpha breakage

barrier.h uses barrier() in non-SMP case. And doesn't include
compiler.h.

Signed-off-by: Al Viro <[email protected]>
----
diff -urN RC14-rc5-git5-base/include/asm-alpha/barrier.h current/include/asm-alpha/barrier.h
--- RC14-rc5-git5-base/include/asm-alpha/barrier.h 2005-10-26 01:00:39.000000000 -0400
+++ current/include/asm-alpha/barrier.h 2005-10-26 03:38:24.000000000 -0400
@@ -1,6 +1,8 @@
#ifndef __BARRIER_H
#define __BARRIER_H

+#include <linux/compiler.h>
+
#define mb() \
__asm__ __volatile__("mb": : :"memory")

2005-10-26 12:21:54

by Ivan Kokshaysky

Subject: Re: [PATCH] fix alpha breakage

On Wed, Oct 26, 2005 at 11:06:23AM +0100, Al Viro wrote:
> barrier.h uses barrier() in non-SMP case. And doesn't include
> compiler.h.

Thanks, but better use <asm-alpha/compiler.h> because of potential
problems with the "inline" redefinition.

Ivan.

--- 2.6.14-rc5-git6/include/asm-alpha/barrier.h Wed Oct 26 14:43:16 2005
+++ linux/include/asm-alpha/barrier.h Wed Oct 26 15:03:47 2005
@@ -1,6 +1,8 @@
#ifndef __BARRIER_H
#define __BARRIER_H

+#include <asm/compiler.h>
+
#define mb() \
__asm__ __volatile__("mb": : :"memory")

2005-10-29 08:53:43

by Norbert Tretkowski

Subject: Re: [PATCH] fix alpha breakage

* Ivan Kokshaysky wrote:
> On Wed, Oct 26, 2005 at 11:06:23AM +0100, Al Viro wrote:
>> barrier.h uses barrier() in non-SMP case. And doesn't include
>> compiler.h.
>
> Thanks, but better use <asm-alpha/compiler.h> because of potential
> problems with the "inline" redefinition.

Uhm, looks like this wasn't included in the final 2.6.14 release.

Norbert