2005-10-27 19:30:43

by Kristen Carlson Accardi

[permalink] [raw]
Subject: [patch 0/3] pci: store PCI_INTERRUPT_PIN in pci_dev

Store the value of PCI_INTERRUPT_PIN in the pci_dev structure for use
later. This is useful for pci hotplug. When a device is "surprise"
removed, the pci config space is no longer available. However,
the pin value is needed to correctly disable the irq for the device.

--


2005-10-27 19:38:37

by Arjan van de Ven

[permalink] [raw]
Subject: Re: [patch 0/3] pci: store PCI_INTERRUPT_PIN in pci_dev

On Thu, 2005-10-27 at 12:30 -0700, Kristen Accardi wrote:
> Store the value of PCI_INTERRUPT_PIN in the pci_dev structure for use
> later. This is useful for pci hotplug. When a device is "surprise"
> removed, the pci config space is no longer available. However,
> the pin value is needed to correctly disable the irq for the device.

Hmmm maybe it's just me..... but... isn't that both advisory and
entirely unrelated to any kind of real interrupt thing? Eg dev->irq is
there already and works even in the sight of IO-APICs etc etc...


2005-10-27 19:46:14

by Matthew Wilcox

[permalink] [raw]
Subject: Re: [Pcihpd-discuss] Re: [patch 0/3] pci: store PCI_INTERRUPT_PIN in pci_dev

On Thu, Oct 27, 2005 at 09:38:17PM +0200, Arjan van de Ven wrote:
> On Thu, 2005-10-27 at 12:30 -0700, Kristen Accardi wrote:
> > Store the value of PCI_INTERRUPT_PIN in the pci_dev structure for use
> > later. This is useful for pci hotplug. When a device is "surprise"
> > removed, the pci config space is no longer available. However,
> > the pin value is needed to correctly disable the irq for the device.
>
> Hmmm maybe it's just me..... but... isn't that both advisory and
> entirely unrelated to any kind of real interrupt thing? Eg dev->irq is
> there already and works even in the sight of IO-APICs etc etc...

With surprise hotplug, we can't read the pin from the card any more...