2005-10-28 20:33:28

by Adrian Bunk

Subject: [2.6 patch] fix XFS_QUOTA for modular XFS

This patch by Dimitri Puzin submitted through kernel Bugzilla #5514
fixes the following issue:

Cannot build XFS filesystem support as module with quota support. It
works only when the XFS filesystem support is compiled into the kernel.
Menuconfig prevents from setting CONFIG_XFS_FS=m and CONFIG_XFS_QUOTA=y.

How to reproduce: configure the XFS filesystem with quota support as
module. The resulting kernel won't have quota support compiled into
xfs.ko.

Fix: Changing the fs/xfs/Kconfig file from tristate to bool lets you
configure the quota support to be compiled into the XFS module. The
Makefile-linux-2.6 checks only for CONFIG_XFS_QUOTA=y.


From: Dimitri Puzin <[email protected]>
Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.14-rc5-mm1/fs/xfs/Kconfig.old 2005-10-28 19:51:02.000000000 +0200
+++ linux-2.6.14-rc5-mm1/fs/xfs/Kconfig 2005-10-28 19:51:12.000000000 +0200
@@ -24,7 +24,7 @@
default y

config XFS_QUOTA
- tristate "XFS Quota support"
+ bool "XFS Quota support"
depends on XFS_FS
help
If you say Y here, you will be able to set limits for disk usage on

2005-10-28 21:18:16

by Nathan Scott

Subject: Re: [2.6 patch] fix XFS_QUOTA for modular XFS

On Fri, Oct 28, 2005 at 10:33:25PM +0200, Adrian Bunk wrote:
> This patch by Dimitri Puzin submitted through kernel Bugzilla #5514
> fixes the following issue:
> ...
> From: Dimitri Puzin <[email protected]>
> Signed-off-by: Adrian Bunk <[email protected]>

Thanks guys; feel free to add:
Signed-off-by: Nathan Scott <[email protected]>

(Or Acked-by: or whatever).

cheers.

--
Nathan

2005-10-31 21:03:47

by Chris Wright

Subject: Re: [stable] [2.6 patch] fix XFS_QUOTA for modular XFS

* Adrian Bunk ([email protected]) wrote:
> This patch by Dimitri Puzin submitted through kernel Bugzilla #5514
> fixes the following issue:
>
> Cannot build XFS filesystem support as module with quota support. It
> works only when the XFS filesystem support is compiled into the kernel.
> Menuconfig prevents from setting CONFIG_XFS_FS=m and CONFIG_XFS_QUOTA=y.

Thanks, will queue for -stable, but this hasn't made it upstream yet.

thanks,
-chris

2005-10-31 21:16:19

by Nathan Scott

Subject: Re: [stable] [2.6 patch] fix XFS_QUOTA for modular XFS

On Mon, Oct 31, 2005 at 01:03:05PM -0800, Chris Wright wrote:
> * Adrian Bunk ([email protected]) wrote:
> > This patch by Dimitri Puzin submitted through kernel Bugzilla #5514
> > fixes the following issue:
> >
> > Cannot build XFS filesystem support as module with quota support. It
> > works only when the XFS filesystem support is compiled into the kernel.
> > Menuconfig prevents from setting CONFIG_XFS_FS=m and CONFIG_XFS_QUOTA=y.
>
> Thanks, will queue for -stable, but this hasn't made it upstream yet.

Sorry, public holiday here has meant no action on that front - it
is "good to go" though, and will be sent to Linus when I'm back in
the office.

cheers.

--
Nathan