2005-11-01 19:15:12

by Santiago Leon

[permalink] [raw]
Subject: [PATCH] ibmveth fix panic in initial replenish cycle

This patch fixes a panic in the current tree caused by a race condition between the initial replenish cycle and the rx processing of the first packets trying to replenish the buffers.

Signed-off-by: Santiago Leon <[email protected]>

diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c
--- a/drivers/net/ibmveth.c
+++ b/drivers/net/ibmveth.c
@@ -535,7 +535,7 @@ static int ibmveth_open(struct net_devic
}

ibmveth_debug_printk("initial replenish cycle\n");
- ibmveth_replenish_task(adapter);
+ ibmveth_interrupt(netdev->irq, netdev, NULL);

netif_start_queue(netdev);


2005-11-04 22:25:36

by John W. Linville

[permalink] [raw]
Subject: Re: [PATCH] ibmveth fix panic in initial replenish cycle

On Tue, Nov 01, 2005 at 02:15:09PM -0500, Santiago Leon wrote:
> This patch fixes a panic in the current tree caused by a race condition between the initial replenish cycle and the rx processing of the first packets trying to replenish the buffers.

Please restrain your line widths to less than 80 characters. 72 is
a nice number IMHO.

Thanks,

John
--
John W. Linville
[email protected]