2005-11-02 18:39:12

by Chris Wedgwood

Subject: Re: [BLOCK] Unify the seperate read/write io stat fields into arrays

I wouldn't mind a comment with that:

> struct disk_stats {
> - unsigned read_sectors, write_sectors;
> - unsigned reads, writes;
> - unsigned read_merges, write_merges;
> - unsigned read_ticks, write_ticks;
/* Element 0 is for reads, 1 for writes */
> + unsigned sectors[2];
> + unsigned ios[2];
> + unsigned merges[2];
> + unsigned ticks[2];
> unsigned io_ticks;
> unsigned time_in_queue;
> };

2005-11-03 07:31:28

by Jens Axboe

Subject: Re: [BLOCK] Unify the seperate read/write io stat fields into arrays

On Wed, Nov 02 2005, Chris Wedgwood wrote:
> I wouldn't mind a comment with that:
>
> > struct disk_stats {
> > - unsigned read_sectors, write_sectors;
> > - unsigned reads, writes;
> > - unsigned read_merges, write_merges;
> > - unsigned read_ticks, write_ticks;
> /* Element 0 is for reads, 1 for writes */
> > + unsigned sectors[2];
> > + unsigned ios[2];
> > + unsigned merges[2];
> > + unsigned ticks[2];
> > unsigned io_ticks;
> > unsigned time_in_queue;
> > };

Then send me such a comment patch :-)

--
Jens Axboe