2005-11-05 23:49:46

by Michael Hanselmann

Subject: [PATCH] Framebuffer mode required for PowerBook Titanium

This patch adds the framebuffer mode required for an Apple PowerBook G4
Titanium.

Signed-off-by: Michael Hanselmann <[email protected]>

---
--- linux-2.6.14/drivers/video/modedb.c.orig 2005-11-05 22:29:02.000000000 +0100
+++ linux-2.6.14/drivers/video/modedb.c 2005-11-05 22:31:15.000000000 +0100
@@ -251,6 +251,10 @@ static const struct fb_videomode modedb[
NULL, 60, 1920, 1200, 5177, 128, 336, 1, 38, 208, 3,
FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
FB_VMODE_NONINTERLACED
+ }, {
+ /* 1152x768, 60 Hz, PowerBook G4 Titanium I and II */
+ "mac21", 60, 1152, 768, 15386, 158, 26, 29, 3, 136, 6,
+ FB_SYNC_HOR_HIGH_ACT|FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED
},
};

2005-11-06 00:11:43

by Antonino A. Daplas

Subject: Re: [PATCH] Framebuffer mode required for PowerBook Titanium

Michael Hanselmann wrote:
> This patch adds the framebuffer mode required for an Apple PowerBook G4
> Titanium.
>

Does booting with video=xxxfb:1152x768M@60 work? If it does, I would prefer
that we avoid adding more entries to the global mode database.

Tony

2005-11-06 00:19:23

by Benjamin Herrenschmidt

Subject: Re: [PATCH] Framebuffer mode required for PowerBook Titanium

On Sun, 2005-11-06 at 00:49 +0100, Michael Hanselmann wrote:
> This patch adds the framebuffer mode required for an Apple PowerBook G4
> Titanium.
>
> Signed-off-by: Michael Hanselmann <[email protected]>
>
> ---
> --- linux-2.6.14/drivers/video/modedb.c.orig 2005-11-05 22:29:02.000000000 +0100
> +++ linux-2.6.14/drivers/video/modedb.c 2005-11-05 22:31:15.000000000 +0100
> @@ -251,6 +251,10 @@ static const struct fb_videomode modedb[
> NULL, 60, 1920, 1200, 5177, 128, 336, 1, 38, 208, 3,
> FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
> FB_VMODE_NONINTERLACED
> + }, {
> + /* 1152x768, 60 Hz, PowerBook G4 Titanium I and II */
> + "mac21", 60, 1152, 768, 15386, 158, 26, 29, 3, 136, 6,
> + FB_SYNC_HOR_HIGH_ACT|FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED
> },
> };

Please, re-do it without the "mac21" name, just leave NULL there.

Ben.

2005-11-06 00:30:22

by Michael Hanselmann

Subject: Re: [PATCH] Framebuffer mode required for PowerBook Titanium

> Does booting with video=xxxfb:1152x768M@60 work? If it does, I would prefer
> that we avoid adding more entries to the global mode database.

It boots but the picture is stretched over the display. That's what I
first tried, too, but only adding the mode definition fixed it.

Greets,
Michael

2005-11-06 00:39:01

by Antonino A. Daplas

Subject: Re: [PATCH] Framebuffer mode required for PowerBook Titanium

Michael Hanselmann wrote:
>> Does booting with video=xxxfb:1152x768M@60 work? If it does, I would prefer
>> that we avoid adding more entries to the global mode database.
>
> It boots but the picture is stretched over the display. That's what I
> first tried, too, but only adding the mode definition fixed it.

Okay.

Tony

2005-11-06 00:49:36

by Michael Hanselmann

Subject: Re: [PATCH] Framebuffer mode required for PowerBook Titanium

This patch adds the framebuffer mode required for an Apple PowerBook G4
Titanium.

---

Redone with NULL instead of "mac21".

--- linux-2.6.14/drivers/video/modedb.c.orig 2005-11-05 22:29:02.000000000 +0100
+++ linux-2.6.14/drivers/video/modedb.c 2005-11-06 01:33:27.000000000 +0100
@@ -251,6 +251,10 @@
NULL, 60, 1920, 1200, 5177, 128, 336, 1, 38, 208, 3,
FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
FB_VMODE_NONINTERLACED
+ }, {
+ /* 1152x768, 60 Hz, PowerBook G4 Titanium I and II */
+ NULL, 60, 1152, 768, 15386, 158, 26, 29, 3, 136, 6,
+ FB_SYNC_HOR_HIGH_ACT|FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED
},
};

2005-11-06 01:39:52

by Antonino A. Daplas

Subject: Re: [PATCH] Framebuffer mode required for PowerBook Titanium

Michael Hanselmann wrote:
> This patch adds the framebuffer mode required for an Apple PowerBook G4
> Titanium.

Feel free to add my

Acked-by: Antonino Daplas <[email protected]>