2005-11-16 17:31:30

by Matt Domsch

Subject: [PATCH 2.6.15-rc] ipmi: missing NULL test for kthread

On IPMI systems with BT interfaces, we don't start the kernel thread,
so smi_info->thread is NULL. Test for NULL when stopping the thread,
because kthread_stop() doesn't, and an oops ensues otherwise.

Signed-off-by: Matt Domsch <[email protected]>

--
Matt Domsch
Software Architect
Dell Linux Solutions linux.dell.com & http://www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

diff -urNp --exclude-from=/home/mdomsch/excludes --minimal linux-2.6/drivers/char/ipmi/ipmi_si_intf.c linux-2.6.ipmi/drivers/char/ipmi/ipmi_si_intf.c
--- linux-2.6/drivers/char/ipmi/ipmi_si_intf.c Wed Nov 16 08:45:57 2005
+++ linux-2.6.ipmi/drivers/char/ipmi/ipmi_si_intf.c Wed Nov 16 08:49:12 2005
@@ -2203,7 +2203,7 @@ static void setup_xaction_handlers(struc

static inline void wait_for_timer_and_thread(struct smi_info *smi_info)
{
- if (smi_info->thread != ERR_PTR(-ENOMEM))
+ if (smi_info->thread != NULL && smi_info->thread != ERR_PTR(-ENOMEM))
kthread_stop(smi_info->thread);
del_timer_sync(&smi_info->si_timer);
}

2005-11-16 19:30:46

by Corey Minyard

Subject: Re: [Openipmi-developer] [PATCH 2.6.15-rc] ipmi: missing NULL test for kthread

Matt Domsch wrote:

>On IPMI systems with BT interfaces, we don't start the kernel thread,
>so smi_info->thread is NULL. Test for NULL when stopping the thread,
>because kthread_stop() doesn't, and an oops ensues otherwise.
>
>Signed-off-by: Matt Domsch <[email protected]>
>
>
>
Yes, obvious fix, please apply. I wish I had a system with a BT
interface :(. Of course, then I'd have to find a place to put it, and
I'd have an unhappy wife...

-Corey