2005-11-20 06:47:35

by Dmitry Torokhov

[permalink] [raw]
Subject: [git pull 03/14] Wistron - disable for x86_64

From: Andrew Morton <[email protected]>

Input: wistron - disable for x86_64

On x86_64:

{standard input}:233: Error: suffix or operands invalid for `push'
{standard input}:233: Error: suffix or operands invalid for `pop'

Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Dmitry Torokhov <[email protected]>
---

drivers/input/misc/Kconfig | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

Index: work/drivers/input/misc/Kconfig
===================================================================
--- work.orig/drivers/input/misc/Kconfig
+++ work/drivers/input/misc/Kconfig
@@ -42,7 +42,7 @@ config INPUT_M68K_BEEP

config INPUT_WISTRON_BTNS
tristate "x86 Wistron laptop button interface"
- depends on X86
+ depends on X86 && !X86_64
help
Say Y here for support of Winstron laptop button interface, used on
laptops of various brands, including Acer and Fujitsu-Siemens.


2005-11-20 09:52:16

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [git pull 03/14] Wistron - disable for x86_64

On Sun, 20 Nov 2005, Dmitry Torokhov wrote:
> From: Andrew Morton <[email protected]>
>
> Input: wistron - disable for x86_64
>
> On x86_64:
>
> {standard input}:233: Error: suffix or operands invalid for `push'
> {standard input}:233: Error: suffix or operands invalid for `pop'
>
> Signed-off-by: Andrew Morton <[email protected]>
> Signed-off-by: Dmitry Torokhov <[email protected]>
> ---
>
> drivers/input/misc/Kconfig | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: work/drivers/input/misc/Kconfig
> ===================================================================
> --- work.orig/drivers/input/misc/Kconfig
> +++ work/drivers/input/misc/Kconfig
> @@ -42,7 +42,7 @@ config INPUT_M68K_BEEP
>
> config INPUT_WISTRON_BTNS
> tristate "x86 Wistron laptop button interface"
> - depends on X86
> + depends on X86 && !X86_64
^^^^^^^^^^^^^^
That should be just `X86_32' these days.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2005-11-22 03:42:12

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [git pull 03/14] Wistron - disable for x86_64

On Sunday 20 November 2005 04:52, Geert Uytterhoeven wrote:
> On Sun, 20 Nov 2005, Dmitry Torokhov wrote:
> >
> > config INPUT_WISTRON_BTNS
> > tristate "x86 Wistron laptop button interface"
> > - depends on X86
> > + depends on X86 && !X86_64
> ^^^^^^^^^^^^^^
> That should be just `X86_32' these days.
>

Oh, I wasn't aware of the new symbol. I will have that changed with the
next batch.

Thanks!

--
Dmitry