2005-12-14 02:17:06

by Dave Jones

[permalink] [raw]
Subject: Re: [IA64] Change SET_PERSONALITY to comply with comment in binfmt_elf.c.

On Mon, Dec 12, 2005 at 05:59:48PM -0800, Linux Kernel wrote:
> tree 64fc1ba7d4734ea5ecec8942795b32a32e4623a4
> parent acb7f67280128a9ddaa756ff10212391d28caec4
> author Robin Holt <[email protected]> Tue, 06 Dec 2005 08:02:31 -0600
> committer Tony Luck <[email protected]> Wed, 07 Dec 2005 01:12:34 -0800
>
> [IA64] Change SET_PERSONALITY to comply with comment in binfmt_elf.c.

This introduces a compile failure.

arch/ia64/kernel/process.c: In function 'flush_thread':
arch/ia64/kernel/process.c:731: error: 'IA32_PAGE_OFFSET' undeclared (first use in this function)
arch/ia64/kernel/process.c:731: error: (Each undeclared identifier is reported only once
arch/ia64/kernel/process.c:731: error: for each function it appears in.)

Dave


2005-12-14 12:58:14

by Robin Holt

[permalink] [raw]
Subject: [Patch] Complete fix for SET_PERSONALITY when CONFIG_IA32_SUPPORT is not set.

Missed this when fixing the SET_PERSONALITY change.

Signed-off-by: Robin Holt <[email protected]>


Index: linux-2.6/arch/ia64/kernel/process.c
===================================================================
--- linux-2.6.orig/arch/ia64/kernel/process.c 2005-12-14 06:49:33.512127321 -0600
+++ linux-2.6/arch/ia64/kernel/process.c 2005-12-14 06:52:07.488250554 -0600
@@ -721,11 +721,13 @@ flush_thread (void)
/* drop floating-point and debug-register state if it exists: */
current->thread.flags &= ~(IA64_THREAD_FPH_VALID | IA64_THREAD_DBG_VALID);
ia64_drop_fpu(current);
+#ifdef CONFIG_IA32_SUPPORT
if (IS_IA32_PROCESS(ia64_task_regs(current))) {
ia32_drop_partial_page_list(current);
current->thread.task_size = IA32_PAGE_OFFSET;
set_fs(USER_DS);
}
+#endif
}

/*