iSeries has no keyboard, so it's valid to build a kernel with no input layer.
It seems a bit absurd to call one of these 'embedded'.
Signed-off-by: Dave Jones <[email protected]>
--- linux-2.6.15/drivers/input/Kconfig~ 2006-01-06 02:27:56.000000000 -0500
+++ linux-2.6.15/drivers/input/Kconfig 2006-01-06 02:28:08.000000000 -0500
@@ -5,7 +5,7 @@
menu "Input device support"
config INPUT
- tristate "Generic input layer (needed for keyboard, mouse, ...)" if EMBEDDED
+ tristate "Generic input layer (needed for keyboard, mouse, ...)"
default y
---help---
Say Y here if you have any input device (mouse, keyboard, tablet,
On Fri, Jan 06, 2006 at 02:38:19AM -0500, Dave Jones wrote:
> iSeries has no keyboard, so it's valid to build a kernel with no input layer.
> It seems a bit absurd to call one of these 'embedded'.
Please just remove the EMBEDDED here - there's tons of plattforms without
input that certainly aren't embedded. In fact I've seen very few non-x86
servers with any input devices.
On Fri, Jan 06, 2006 at 09:06:41AM +0000, Christoph Hellwig wrote:
> On Fri, Jan 06, 2006 at 02:38:19AM -0500, Dave Jones wrote:
> > iSeries has no keyboard, so it's valid to build a kernel with no input layer.
> > It seems a bit absurd to call one of these 'embedded'.
>
> Please just remove the EMBEDDED here - there's tons of plattforms without
> input that certainly aren't embedded. In fact I've seen very few non-x86
> servers with any input devices.
That's what the patch did :)
Dave
On Fri, Jan 06, 2006 at 04:09:46AM -0500, Dave Jones wrote:
> On Fri, Jan 06, 2006 at 09:06:41AM +0000, Christoph Hellwig wrote:
> > On Fri, Jan 06, 2006 at 02:38:19AM -0500, Dave Jones wrote:
> > > iSeries has no keyboard, so it's valid to build a kernel with no input layer.
> > > It seems a bit absurd to call one of these 'embedded'.
> >
> > Please just remove the EMBEDDED here - there's tons of plattforms without
> > input that certainly aren't embedded. In fact I've seen very few non-x86
> > servers with any input devices.
>
> That's what the patch did :)
oops, sorry. I should read the patch and not just the description..
... off and grabbing another tea to really wake up
On Friday 06 January 2006 02:38, Dave Jones wrote:
> iSeries has no keyboard, so it's valid to build a kernel with no input layer.
> It seems a bit absurd to call one of these 'embedded'.
>
> Signed-off-by: Dave Jones <[email protected]>
>
> --- linux-2.6.15/drivers/input/Kconfig~ 2006-01-06 02:27:56.000000000 -0500
> +++ linux-2.6.15/drivers/input/Kconfig 2006-01-06 02:28:08.000000000 -0500
> @@ -5,7 +5,7 @@
> menu "Input device support"
>
> config INPUT
> - tristate "Generic input layer (needed for keyboard, mouse, ...)" if EMBEDDED
> + tristate "Generic input layer (needed for keyboard, mouse, ...)"
> default y
> ---help---
> Say Y here if you have any input device (mouse, keyboard, tablet,
It is there as a precaution... I wonder if we should have it changed to:
if EMBEDDED || !X86
to ensure that we don't have issues on commodity hardware.
--
Dmitry