2006-01-08 06:40:32

by Miloslav Trmac

[permalink] [raw]
Subject: [PATCH] wistron_btns: Fix missing BIOS signature handling

offset can never be < 0 because it has type size_t. The driver
currently oopses on insmod if BIOS does not support the interface,
instead of refusing to load.

Attachments:
wistron-no-entry.patch (640.00 B)

2006-01-08 06:58:07

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH] wistron_btns: Fix missing BIOS signature handling

On Sunday 08 January 2006 01:39, Miloslav Trmac wrote:
> offset can never be < 0 because it has type size_t. The driver
> currently oopses on insmod if BIOS does not support the interface,
> instead of refusing to load.
>

I don't really like that casting, should we just change offset to ssize_t?

--
Dmitry

2006-01-08 07:52:48

by Miloslav Trmac

[permalink] [raw]
Subject: [PATCH] wistron_btns: Fix missing BIOS signature handling, take 2

Dmitry Torokhov wrote:
> On Sunday 08 January 2006 01:39, Miloslav Trmac wrote:
>
>>offset can never be < 0 because it has type size_t. The driver
>>currently oopses on insmod if BIOS does not support the interface,
>>instead of refusing to load.
>
> I don't really like that casting, should we just change offset to ssize_t?
Sure.
Mirek

Attachments:
wistron-no-entry.patch (925.00 B)

2006-01-08 16:13:23

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH] wistron_btns: Fix missing BIOS signature handling, take 2

On Sunday 08 January 2006 02:52, Miloslav Trmac wrote:
> Dmitry Torokhov wrote:
> > On Sunday 08 January 2006 01:39, Miloslav Trmac wrote:
> >
> >>offset can never be < 0 because it has type size_t. The driver
> >>currently oopses on insmod if BIOS does not support the interface,
> >>instead of refusing to load.
> >
> > I don't really like that casting, should we just change offset to ssize_t?
> Sure.
> Mirek
>

Thank you, I will add this to input tree.

--
Dmitry