2006-01-07 23:44:57

by Patrick McHardy

[permalink] [raw]

Subject: [W1]: Remove incorrect MODULE_ALIAS

---

[W1]: Remove incorrect MODULE_ALIAS

The w1 netlink socket is created by a hardware specific driver calling
w1_add_master_device, so there is no point in including a module alias
for netlink autoloading in the core.

Signed-off-by: Patrick McHardy <[email protected]>

---
commit a8657adb8c04bbe30544306ec55005a635ba65fd
tree 2c029cf104239958220629d34c76c7290bd99e43
parent b73952761225e41cb81afe157cb312a594a95693
author Patrick McHardy <[email protected]> Sun, 08 Jan 2006 00:42:42 +0100
committer Patrick McHardy <[email protected]> Sun, 08 Jan 2006 00:42:42 +0100

drivers/w1/w1_int.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/w1/w1_int.c b/drivers/w1/w1_int.c
index c3f67ea..e2920f0 100644
--- a/drivers/w1/w1_int.c
+++ b/drivers/w1/w1_int.c
@@ -217,5 +217,3 @@ void w1_remove_master_device(struct w1_b

EXPORT_SYMBOL(w1_add_master_device);
EXPORT_SYMBOL(w1_remove_master_device);
-
-MODULE_ALIAS_NET_PF_PROTO(PF_NETLINK, NETLINK_W1);

---

Attachments:

x (978.00 B)

2006-01-08 09:41:01

by Evgeniy Polyakov

[permalink] [raw]

Subject: Re: [W1]: Remove incorrect MODULE_ALIAS

---

On Sun, Jan 08, 2006 at 12:44:15AM +0100, Patrick McHardy ([email protected]) wrote:

> [W1]: Remove incorrect MODULE_ALIAS
>
> The w1 netlink socket is created by a hardware specific driver calling
> w1_add_master_device, so there is no point in including a module alias
> for netlink autoloading in the core.
>
> Signed-off-by: Patrick McHardy <[email protected]>

ACK.
Thanks, Patrick.

> ---
> commit a8657adb8c04bbe30544306ec55005a635ba65fd
> tree 2c029cf104239958220629d34c76c7290bd99e43
> parent b73952761225e41cb81afe157cb312a594a95693
> author Patrick McHardy <[email protected]> Sun, 08 Jan 2006 00:42:42 +0100
> committer Patrick McHardy <[email protected]> Sun, 08 Jan 2006 00:42:42 +0100
>
> drivers/w1/w1_int.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/w1/w1_int.c b/drivers/w1/w1_int.c
> index c3f67ea..e2920f0 100644
> --- a/drivers/w1/w1_int.c
> +++ b/drivers/w1/w1_int.c
> @@ -217,5 +217,3 @@ void w1_remove_master_device(struct w1_b
>
> EXPORT_SYMBOL(w1_add_master_device);
> EXPORT_SYMBOL(w1_remove_master_device);
> -
> -MODULE_ALIAS_NET_PF_PROTO(PF_NETLINK, NETLINK_W1);


--
Evgeniy Polyakov