2006-01-12 20:43:40

by Chris Wedgwood

[permalink] [raw]
Subject: Re: [XFS] Do not inherit properties for the quota inodes from the root inode.

On Thu, Jan 12, 2006 at 10:15:34AM -0800, Linux Kernel Mailing List wrote:
> tree 589ad79019067e1b82006bacf6c10d1d717a46dc
> parent 4ef19dddbaf2f24e492c18112fd8a04ce116daca
> author Nathan Scott <[email protected]> Wed, 11 Jan 2006 15:27:50 +1100
> committer Nathan Scott <[email protected]> Wed, 11 Jan 2006 15:27:50 +1100
>
> [XFS] Do not inherit properties for the quota inodes from the root inode.

lots of whitespace changes... :)

>
> - if ((error = xfs_dir_ialloc(&tp, mp->m_rootip, S_IFREG, 1, 0,
> + if ((error = xfs_dir_ialloc(&tp, &zeroino, S_IFREG, 1, 0,
> &zerocr, 0, 1, ip, &committed))) {
> xfs_trans_cancel(tp, XFS_TRANS_RELEASE_LOG_RES |
> XFS_TRANS_ABORT);

why would you want to do this at all?


2006-01-12 21:15:48

by Nathan Scott

[permalink] [raw]
Subject: Re: [XFS] Do not inherit properties for the quota inodes from the root inode.

Hi Chris,

On Thu, Jan 12, 2006 at 12:43:36PM -0800, Chris Wedgwood wrote:
> > [XFS] Do not inherit properties for the quota inodes from the root inode.
>
> lots of whitespace changes... :)

If by "lots" you mean "one line", then yes!

> >
> > - if ((error = xfs_dir_ialloc(&tp, mp->m_rootip, S_IFREG, 1, 0,
> > + if ((error = xfs_dir_ialloc(&tp, &zeroino, S_IFREG, 1, 0,
> > &zerocr, 0, 1, ip, &committed))) {
> > xfs_trans_cancel(tp, XFS_TRANS_RELEASE_LOG_RES |
> > XFS_TRANS_ABORT);
>
> why would you want to do this at all?

I'm not sure what you're asking? There are things we do not
want to inherit from the root inode (certain inode flags in
particular) when the quota inodes are being created... does
that help?

cheers.

--
Nathan