2006-01-13 03:52:12

by Qi Yong

[permalink] [raw]
Subject: abandon gcc 295x main.c tidy

Hello,

After abandon-gcc-295x.patch, this relocates the
error-out-early comment.

Signed-off-by: Coywolf Qi Hunt <[email protected]>
---

diff --git a/init/main.c b/init/main.c
index e092b19..22c4ff5 100644
--- a/init/main.c
+++ b/init/main.c
@@ -54,15 +54,15 @@
#include <asm/sections.h>
#include <asm/cacheflush.h>

+#ifdef CONFIG_X86_LOCAL_APIC
+#include <asm/smp.h>
+#endif
+
/*
* This is one of the first .c files built. Error out early
* if we have compiler trouble..
*/

-#ifdef CONFIG_X86_LOCAL_APIC
-#include <asm/smp.h>
-#endif
-
/*
* Versions of gcc older than that listed below may actually compile
* and link okay, but the end product can have subtle run time bugs.

--
Coywolf Qi Hunt


2006-01-16 17:10:36

by Horst H. von Brand

[permalink] [raw]
Subject: Re: abandon gcc 295x main.c tidy

Coywolf Qi Hunt <[email protected]> wrote:
> After abandon-gcc-295x.patch, this relocates the
> error-out-early comment.

What for?
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513

2006-01-17 00:57:53

by Qi Yong

[permalink] [raw]
Subject: Re: abandon gcc 295x main.c tidy

On Sun, Jan 15, 2006 at 01:27:00AM -0300, Horst von Brand wrote:
> Coywolf Qi Hunt <[email protected]> wrote:
> > After abandon-gcc-295x.patch, this relocates the
> > error-out-early comment.
>
> What for?

It looks like this now:
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=69c99ac17e2ee0eb45e2c9873e6e12d73260fc6b

Also read abandon-gcc-295x.patch to see what for.
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.15-rc5/2.6.15-rc5-mm3/broken-out/abandon-gcc-295x.patch
--
Coywolf Qi Hunt