2006-01-13 03:19:39

by Chris Wright

Subject: [PATCH 15/17] [PATCH] moxa serial: add proper capability check

-stable review patch. If anyone has any objections, please let us know.
------------------

This requires the proper capabilities for the moxa bios update ioctl's.

Signed-off-by: Linus Torvalds <[email protected]>
Signed-off-by: Chris Wright <[email protected]>
---
drivers/char/moxa.c | 2 ++
1 file changed, 2 insertions(+)

--- linux-2.6.15.y.orig/drivers/char/moxa.c
+++ linux-2.6.15.y/drivers/char/moxa.c
@@ -1661,6 +1661,8 @@ int MoxaDriverIoctl(unsigned int cmd, un
case MOXA_FIND_BOARD:
case MOXA_LOAD_C320B:
case MOXA_LOAD_CODE:
+ if (!capable(CAP_SYS_RAWIO))
+ return -EPERM;
break;
}


--

2006-01-13 09:01:38

by Alan Cox

Subject: Re: [PATCH 15/17] [PATCH] moxa serial: add proper capability check

On Thu, Jan 12, 2006 at 06:37:53PM -0800, Chris Wright wrote:
> -stable review patch. If anyone has any objections, please let us know.
> ------------------
>
> This requires the proper capabilities for the moxa bios update ioctl's.
>
> Signed-off-by: Linus Torvalds <[email protected]>
> Signed-off-by: Chris Wright <[email protected]>
Signed-off-by: Alan Cox <[email protected]>