2006-01-17 23:55:50

by Dave Jones

Subject: 2.6.16rc1 ia64 missing symbol..

kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_unregister_submodule

CONFIG_SERIAL_SGI_IOC3=m
CONFIG_SGI_IOC3=m

Dave

2006-01-18 11:02:53

by Jes Sorensen

Subject: Re: 2.6.16rc1 ia64 missing symbol..

>>>>> "Dave" == Dave Jones <[email protected]> writes:

Dave> kernel/drivers/serial/ioc3_serial.ko needs unknown symbol
Dave> ioc3_unregister_submodule CONFIG_SERIAL_SGI_IOC3=m
Dave> CONFIG_SGI_IOC3=m

Just tried it and it works fine for me:

margin:~ # insmod ioc3.ko
margin:~ # insmod ioc3_serial.ko
margin:~ #

This is with the latest git tree from Linus this morning.

Cheers,
Jes

2006-01-19 00:21:30

by Dave Jones

Subject: Re: 2.6.16rc1 ia64 missing symbol..

On Wed, Jan 18, 2006 at 06:02:45AM -0500, Jes Sorensen wrote:
> >>>>> "Dave" == Dave Jones <[email protected]> writes:
>
> Dave> kernel/drivers/serial/ioc3_serial.ko needs unknown symbol
> Dave> ioc3_unregister_submodule CONFIG_SERIAL_SGI_IOC3=m
> Dave> CONFIG_SGI_IOC3=m
>
> Just tried it and it works fine for me:
>
> margin:~ # insmod ioc3.ko
> margin:~ # insmod ioc3_serial.ko
> margin:~ #
>
> This is with the latest git tree from Linus this morning.

I still see problems with the latest Linus tree.

kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_unregister_submodule
kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_disable
kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_gpcr_set
kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_ack
kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_register_submodule
kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_enable
kernel/drivers/pci/hotplug/rpaphp.ko needs unknown symbol pci_claim_resource

full .config at http://people.redhat.com/davej/ia64.config

Dave

2006-01-19 03:24:27

by Adrian Bunk

Subject: [2.6 patch] drivers/sn/ must be entered for CONFIG_SGI_IOC3

On Tue, Jan 17, 2006 at 06:55:21PM -0500, Dave Jones wrote:

> kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_unregister_submodule
>
> CONFIG_SERIAL_SGI_IOC3=m
> CONFIG_SGI_IOC3=m

The untested patch below should fix it.

> Dave

cu
Adrian


<-- snip -->


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.16-rc1-mm1-full/drivers/Makefile.old 2006-01-19 04:14:24.000000000 +0100
+++ linux-2.6.16-rc1-mm1-full/drivers/Makefile 2006-01-19 04:14:57.000000000 +0100
@@ -70,6 +70,7 @@
obj-$(CONFIG_CPU_FREQ) += cpufreq/
obj-$(CONFIG_MMC) += mmc/
obj-$(CONFIG_INFINIBAND) += infiniband/
+obj-$(CONFIG_SGI_IOC3) += sn/
obj-$(CONFIG_SGI_IOC4) += sn/
obj-y += firmware/
obj-$(CONFIG_CRYPTO) += crypto/

2006-01-19 09:54:05

by Jes Sorensen

Subject: Re: [2.6 patch] drivers/sn/ must be entered for CONFIG_SGI_IOC3

>>>>> "Adrian" == Adrian Bunk <[email protected]> writes:

Adrian> On Tue, Jan 17, 2006 at 06:55:21PM -0500, Dave Jones wrote:
>> kernel/drivers/serial/ioc3_serial.ko needs unknown symbol
>> ioc3_unregister_submodule
>>
>> CONFIG_SERIAL_SGI_IOC3=m CONFIG_SGI_IOC3=m

Adrian> The untested patch below should fix it.

Actually I think this is more appropriate so we don't end up with 17
cases that add drivers/sn to the build lib.

Dave, does this solve the problem?

Cheers,
Jes

Include drivers/sn when CONFIG_IA64_SGI_SN2 or CONFIG_IA64_GENERIC
is enabled.

Signed-off-by: Jes Sorensen <[email protected]>
----

arch/ia64/Kconfig | 3 +++
drivers/Makefile | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)

Index: linux-2.6/arch/ia64/Kconfig
===================================================================
--- linux-2.6.orig/arch/ia64/Kconfig
+++ linux-2.6/arch/ia64/Kconfig
@@ -374,6 +374,9 @@
To use this option, you have to ensure that the "/proc file system
support" (CONFIG_PROC_FS) is enabled, too.

+config SGI_SN
+ def_bool y if (IA64_SGI_SN2 || IA64_GENERIC)
+
source "drivers/firmware/Kconfig"

source "fs/Kconfig.binfmt"
Index: linux-2.6/drivers/Makefile
===================================================================
--- linux-2.6.orig/drivers/Makefile
+++ linux-2.6/drivers/Makefile
@@ -69,7 +69,7 @@
obj-$(CONFIG_CPU_FREQ) += cpufreq/
obj-$(CONFIG_MMC) += mmc/
obj-$(CONFIG_INFINIBAND) += infiniband/
-obj-$(CONFIG_SGI_IOC4) += sn/
+obj-$(CONFIG_SGI_SN) += sn/
obj-y += firmware/
obj-$(CONFIG_CRYPTO) += crypto/
obj-$(CONFIG_SUPERH) += sh/

2006-01-19 16:09:47

by Adrian Bunk

Subject: Re: [2.6 patch] drivers/sn/ must be entered for CONFIG_SGI_IOC3

On Thu, Jan 19, 2006 at 04:54:00AM -0500, Jes Sorensen wrote:
> >>>>> "Adrian" == Adrian Bunk <[email protected]> writes:
>
> Adrian> On Tue, Jan 17, 2006 at 06:55:21PM -0500, Dave Jones wrote:
> >> kernel/drivers/serial/ioc3_serial.ko needs unknown symbol
> >> ioc3_unregister_submodule
> >>
> >> CONFIG_SERIAL_SGI_IOC3=m CONFIG_SGI_IOC3=m
>
> Adrian> The untested patch below should fix it.
>
> Actually I think this is more appropriate so we don't end up with 17
> cases that add drivers/sn to the build lib.
>...

I haven't tested your patch, but I agree that it's a better approach
than my patch.

> Cheers,
> Jes
>...

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2006-01-20 02:31:23

by Dave Jones

Subject: Re: [2.6 patch] drivers/sn/ must be entered for CONFIG_SGI_IOC3

On Thu, Jan 19, 2006 at 04:54:00AM -0500, Jes Sorensen wrote:
> >>>>> "Adrian" == Adrian Bunk <[email protected]> writes:
>
> Adrian> On Tue, Jan 17, 2006 at 06:55:21PM -0500, Dave Jones wrote:
> >> kernel/drivers/serial/ioc3_serial.ko needs unknown symbol
> >> ioc3_unregister_submodule
> >>
> >> CONFIG_SERIAL_SGI_IOC3=m CONFIG_SGI_IOC3=m
>
> Adrian> The untested patch below should fix it.
>
> Actually I think this is more appropriate so we don't end up with 17
> cases that add drivers/sn to the build lib.
>
> Dave, does this solve the problem?

Yep, looks like it.

Dave