2006-01-19 22:10:20

by Dave Jones

[permalink] [raw]
Subject: EDAC config cleanup

The AMD76x chipsets aren't used in 64-bit, so don't
offer the driver to the user.

Signed-off-by: Dave Jones <[email protected]>

--- linux-2.6.15.noarch/drivers/edac/Kconfig~ 2006-01-19 17:00:16.000000000 -0500
+++ linux-2.6.15.noarch/drivers/edac/Kconfig 2006-01-19 17:03:33.000000000 -0500
@@ -46,7 +46,7 @@ config EDAC_MM_EDAC

config EDAC_AMD76X
tristate "AMD 76x (760, 762, 768)"
- depends on EDAC_MM_EDAC && PCI
+ depends on EDAC_MM_EDAC && PCI X86_32
help
Support for error detection and correction on the AMD 76x
series of chipsets used with the Athlon processor.


2006-01-19 22:12:13

by Randy Dunlap

[permalink] [raw]
Subject: Re: EDAC config cleanup

On Thu, 19 Jan 2006, Dave Jones wrote:

> The AMD76x chipsets aren't used in 64-bit, so don't
> offer the driver to the user.
>
> Signed-off-by: Dave Jones <[email protected]>
>
> --- linux-2.6.15.noarch/drivers/edac/Kconfig~ 2006-01-19 17:00:16.000000000 -0500
> +++ linux-2.6.15.noarch/drivers/edac/Kconfig 2006-01-19 17:03:33.000000000 -0500
> @@ -46,7 +46,7 @@ config EDAC_MM_EDAC
>
> config EDAC_AMD76X
> tristate "AMD 76x (760, 762, 768)"
> - depends on EDAC_MM_EDAC && PCI
> + depends on EDAC_MM_EDAC && PCI X86_32
^ && ???

> help
> Support for error detection and correction on the AMD 76x
> series of chipsets used with the Athlon processor.
> -

--
~Randy

2006-01-19 22:24:19

by Dave Jones

[permalink] [raw]
Subject: Re: EDAC config cleanup

On Thu, Jan 19, 2006 at 02:12:11PM -0800, Randy.Dunlap wrote:

> > + depends on EDAC_MM_EDAC && PCI X86_32
> ^ && ???

Gah. Of course. (That'll teach me to not test 'obvious' patches :)
Here it is again, unborked. (tested with make ARCH=x86_64 menuconfig)


The AMD76x chipsets aren't used in 64-bit, so don't
offer the driver to the user.

Signed-off-by: Dave Jones <[email protected]>

--- linux-2.6.15.noarch/drivers/edac/Kconfig~ 2006-01-19 17:00:16.000000000 -0500
+++ linux-2.6.15.noarch/drivers/edac/Kconfig 2006-01-19 17:03:33.000000000 -0500
@@ -46,7 +46,7 @@ config EDAC_MM_EDAC

config EDAC_AMD76X
tristate "AMD 76x (760, 762, 768)"
- depends on EDAC_MM_EDAC && PCI
+ depends on EDAC_MM_EDAC && PCI && X86_32
help
Support for error detection and correction on the AMD 76x
series of chipsets used with the Athlon processor.

2006-01-19 22:30:44

by Alan Cox

[permalink] [raw]
Subject: Re: EDAC config cleanup

On Thu, Jan 19, 2006 at 05:23:50PM -0500, Dave Jones wrote:
> The AMD76x chipsets aren't used in 64-bit, so don't
> offer the driver to the user.
>
> Signed-off-by: Dave Jones <[email protected]>

Acked-by: Alan Cox <[email protected]>

2006-01-19 22:30:10

by Alan Cox

[permalink] [raw]
Subject: Re: EDAC config cleanup

On Thu, Jan 19, 2006 at 05:10:06PM -0500, Dave Jones wrote:
> - depends on EDAC_MM_EDAC && PCI
> + depends on EDAC_MM_EDAC && PCI X86_32

NAK add another &&