2006-01-18 20:20:14

by Jan Engelhardt

[permalink] [raw]
Subject: menuconfig elements unaligned

Hi,


in Drivers > Network > 10 or 100Mbit, this shows up:

[*] EISA, VLB, PCI and on board controllers
< > AMD PCnet32 PCI support
< > AMD 8111 (new PCI lance) support
< > Adaptec Starfire/DuraLAN support
< > Broadcom 4400 ethernet support (EXPERIMENTAL)
< > Reverse Engineered nForce Ethernet support (EXPERIMENTAL)
< > Digi Intl. RightSwitch SE-X support
< > EtherExpressPro/100 support (eepro100, original Becker driver)
< > Intel(R) PRO/100+ support

Deactivating EISA would suggest that Digi Intl. and everything below would
remain visible, but they do not. If someone got the time to, please fix it.
Thanks.



Jan Engelhardt
--
| Alphagate Systems, http://alphagate.hopto.org/
| jengelh's site, http://jengelh.hopto.org/


2006-01-18 20:38:07

by Sam Ravnborg

[permalink] [raw]
Subject: Re: menuconfig elements unaligned

On Wed, Jan 18, 2006 at 09:20:11PM +0100, Jan Engelhardt wrote:
> Hi,
>
>
> in Drivers > Network > 10 or 100Mbit, this shows up:
>
> [*] EISA, VLB, PCI and on board controllers
> < > AMD PCnet32 PCI support
> < > AMD 8111 (new PCI lance) support
> < > Adaptec Starfire/DuraLAN support
> < > Broadcom 4400 ethernet support (EXPERIMENTAL)
> < > Reverse Engineered nForce Ethernet support (EXPERIMENTAL)
> < > Digi Intl. RightSwitch SE-X support
> < > EtherExpressPro/100 support (eepro100, original Becker driver)
> < > Intel(R) PRO/100+ support
>
> Deactivating EISA would suggest that Digi Intl. and everything below would
> remain visible, but they do not. If someone got the time to, please fix it.
Looks OK here.
amd64 with defconfig.

Sam

2006-01-23 05:05:18

by Randy Dunlap

[permalink] [raw]
Subject: Re: menuconfig elements unaligned

On Wed, 18 Jan 2006 21:20:11 +0100 (MET) Jan Engelhardt wrote:

> Hi,
>
>
> in Drivers > Network > 10 or 100Mbit, this shows up:
>
> [*] EISA, VLB, PCI and on board controllers
> < > AMD PCnet32 PCI support
> < > AMD 8111 (new PCI lance) support
> < > Adaptec Starfire/DuraLAN support
> < > Broadcom 4400 ethernet support (EXPERIMENTAL)
> < > Reverse Engineered nForce Ethernet support (EXPERIMENTAL)
> < > Digi Intl. RightSwitch SE-X support
> < > EtherExpressPro/100 support (eepro100, original Becker driver)
> < > Intel(R) PRO/100+ support
>
> Deactivating EISA would suggest that Digi Intl. and everything below would
> remain visible, but they do not. If someone got the time to, please fix it.
> Thanks.

Like Sam replied, I don't see a problem. But the indentation shown
above isn't how I see it on-screen. The Digi, EtherExpressPro/100,
and Intel(R) PRO/100+ are all indented under EISA/VLB/PCI for me.


However, here's another one. On ARCH=i386, the top-level menu shows
[ ] Enable doublefault exception handler

(menuconfig or xconfig)
This is from arch/i386/Kconfig (line 50). Surely this should be
under "Processor type and features" or some other menu, not at the
top level.

---
~Randy

2006-01-23 05:22:52

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] menu: relocate DOUBLEFAULT option

From: Randy Dunlap <[email protected]>

Move the DOUBLEFAULT option from the top-level menu to the
EMBEDDED menu. Only applicable to X86_32.

Signed-off-by: Randy Dunlap <[email protected]>
---
arch/i386/Kconfig | 9 ---------
init/Kconfig | 9 +++++++++
2 files changed, 9 insertions(+), 9 deletions(-)

--- linux-2616-rc1g4.orig/arch/i386/Kconfig
+++ linux-2616-rc1g4/arch/i386/Kconfig
@@ -47,15 +47,6 @@ config DMI

source "init/Kconfig"

-config DOUBLEFAULT
- default y
- bool "Enable doublefault exception handler" if EMBEDDED
- help
- This option allows trapping of rare doublefault exceptions that
- would otherwise cause a system to silently reboot. Disabling this
- option saves about 4k and might cause you much additional grey
- hair.
-
menu "Processor type and features"

choice
--- linux-2616-rc1g4.orig/init/Kconfig
+++ linux-2616-rc1g4/init/Kconfig
@@ -412,6 +412,15 @@ config SLAB
SLOB is more space efficient but does not scale well and is
more susceptible to fragmentation.

+config DOUBLEFAULT
+ default y
+ bool "Enable doublefault exception handler" if EMBEDDED && X86_32
+ help
+ This option allows trapping of rare doublefault exceptions that
+ would otherwise cause a system to silently reboot. Disabling this
+ option saves about 4k and might cause you much additional grey
+ hair.
+
endmenu # General setup

config TINY_SHMEM


---

2006-01-23 05:58:00

by Sam Ravnborg

[permalink] [raw]
Subject: Re: menuconfig elements unaligned

On Sun, Jan 22, 2006 at 09:05:24PM -0800, Randy.Dunlap wrote:
>
> However, here's another one. On ARCH=i386, the top-level menu shows
> [ ] Enable doublefault exception handler
>
> (menuconfig or xconfig)
> This is from arch/i386/Kconfig (line 50). Surely this should be
> under "Processor type and features" or some other menu, not at the
> top level.
I recall Andrew has a patch in his queue for this one already.
But not sure and no recent -mm handy.

Sam

2006-01-25 13:54:24

by Jan Engelhardt

[permalink] [raw]
Subject: Re: menuconfig elements unaligned

>> in Drivers > Network > 10 or 100Mbit, this shows up:
>>
>> [*] EISA, VLB, PCI and on board controllers
>> < > AMD PCnet32 PCI support
>> < > AMD 8111 (new PCI lance) support
>> < > Adaptec Starfire/DuraLAN support
>> < > Broadcom 4400 ethernet support (EXPERIMENTAL)
>> < > Reverse Engineered nForce Ethernet support (EXPERIMENTAL)
>> < > Digi Intl. RightSwitch SE-X support
>> < > EtherExpressPro/100 support (eepro100, original Becker driver)
>> < > Intel(R) PRO/100+ support
>>
>> Deactivating EISA would suggest that Digi Intl. and everything below would
>> remain visible, but they do not. If someone got the time to, please fix it.
>> Thanks.
>
>Like Sam replied, I don't see a problem. But the indentation shown
>above isn't how I see it on-screen. The Digi, EtherExpressPro/100,
>and Intel(R) PRO/100+ are all indented under EISA/VLB/PCI for me.

Shrug. Ok, this time, a vanilla 2.6.15 pulled fresh from <mirror
of> kernel.org rather than a suse mod...

+----------------------- Ethernet (10 or 100Mbit) ------------------------+
| Arrow keys navigate the menu. <Enter> selects submenus --->. |
| Highlighted letters are hotkeys. Pressing <Y> includes, <N> excludes, |
| <M> modularizes features. Press <Esc><Esc> to exit, <?> for Help, </> |
| for Search. Legend: [*] built-in [ ] excluded <M> module < > |
| +^(-)-----------------------------------------------------------------+ |
| |[*] EISA, VLB, PCI and on board controllers | |
| |< > AMD PCnet32 PCI support | |
| |< > AMD 8111 (new PCI lance) support | |
| |< > Adaptec Starfire/DuraLAN support | |
| |< > Ansel Communications EISA 3200 support (EXPERIMENTAL) | |
| |< > Apricot Xen-II on board Ethernet | |
| |< > Broadcom 4400 ethernet support (EXPERIMENTAL) | |
| |< > Reverse Engineered nForce Ethernet support (EXPERIMENTAL) | |
| |< > CS89x0 support | |
| |< > Digi Intl. RightSwitch SE-X support | |
| |< > EtherExpressPro/100 support (eepro100, original Becker driver) | |
| +v(+)-----------------------------------------------------------------+ |
+-------------------------------------------------------------------------+
| <Select> < Exit > < Help > |
+-------------------------------------------------------------------------+


Jan Engelhardt
--
| Alphagate Systems, http://alphagate.hopto.org/
| jengelh's site, http://jengelh.hopto.org/

2006-01-25 18:25:11

by Jean Delvare

[permalink] [raw]
Subject: Re: menuconfig elements unaligned

Hi Jan, all,

> Shrug. Ok, this time, a vanilla 2.6.15 pulled fresh from <mirror
> of> kernel.org rather than a suse mod...
>
> +----------------------- Ethernet (10 or 100Mbit) ------------------------+
> | Arrow keys navigate the menu. <Enter> selects submenus --->. |
> | Highlighted letters are hotkeys. Pressing <Y> includes, <N> excludes, |
> | <M> modularizes features. Press <Esc><Esc> to exit, <?> for Help, </> |
> | for Search. Legend: [*] built-in [ ] excluded <M> module < > |
> | +^(-)-----------------------------------------------------------------+ |
> | |[*] EISA, VLB, PCI and on board controllers | |
> | |< > AMD PCnet32 PCI support | |
> | |< > AMD 8111 (new PCI lance) support | |
> | |< > Adaptec Starfire/DuraLAN support | |
> | |< > Ansel Communications EISA 3200 support (EXPERIMENTAL) | |
> | |< > Apricot Xen-II on board Ethernet | |
> | |< > Broadcom 4400 ethernet support (EXPERIMENTAL) | |
> | |< > Reverse Engineered nForce Ethernet support (EXPERIMENTAL) | |
> | |< > CS89x0 support | |
> | |< > Digi Intl. RightSwitch SE-X support | |
> | |< > EtherExpressPro/100 support (eepro100, original Becker driver) | |
> | +v(+)-----------------------------------------------------------------+ |
> +-------------------------------------------------------------------------+
> | <Select> < Exit > < Help > |
> +-------------------------------------------------------------------------+

I reported this problem already:
http://lkml.org/lkml/2005/12/27/119

And the fix was merged 13 days ago:
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=fd85d765b75db608500c783e5bc41b63627957c8

So it's in 2.6.16-rc1 but not in 2.6.15 (nor 2.6.15.1).

Hope that helps,
--
Jean Delvare