2006-01-22 04:37:04

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] mm/slab: add kernel-doc for one function

From: Randy Dunlap <[email protected]>

Fix kernel-doc for calculate_slab_order().

Signed-off-by: Randy Dunlap <[email protected]>
---
mm/slab.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)

--- linux-2616-rc1-secur.orig/mm/slab.c
+++ linux-2616-rc1-secur/mm/slab.c
@@ -1490,8 +1490,13 @@ static inline void set_up_list3s(kmem_ca
}

/**
- * calculate_slab_order - calculate size (page order) of slabs and the number
- * of objects per slab.
+ * calculate_slab_order - calculate size (page order) of slabs
+ * @cachep: pointer to the cache that is being created
+ * @size: size of objects to be created in this cache.
+ * @align: required alignment for the objects.
+ * @flags: slab allocation flags
+ *
+ * Also calculates the number of objects per slab.
*
* This could be made much more intelligent. For now, try to avoid using
* high order pages for slabs. When the gfp() functions are more friendly


---


2006-01-22 20:45:10

by Martin Waitz

[permalink] [raw]
Subject: Re: [PATCH] mm/slab: add kernel-doc for one function

hoi :)

thanks, I applied all three patches to
http://tali.admingilde.org/git/linux-docbook.git,
and I guess Andrew will take care of merging them with Linus.

--
Martin Waitz


Attachments:
(No filename) (177.00 B)
signature.asc (189.00 B)
Digital signature
Download all attachments

2006-01-22 21:19:45

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH] mm/slab: add kernel-doc for one function

On Sun, Jan 22, 2006 at 09:45:07PM +0100, Martin Waitz wrote:
> hoi :)
>
> thanks, I applied all three patches to
> http://tali.admingilde.org/git/linux-docbook.git,
> and I guess Andrew will take care of merging them with Linus.

That is the responsibility of the subsystem maintainer - as you have
become now.
At least in the normal case Andrew suck in the git trees and leave it to
the git tree owners to push to Linus.

It's a bit different compared to when you just sent patches to Andrew.

Sam

2006-01-22 21:51:37

by Martin Waitz

[permalink] [raw]
Subject: Re: [PATCH] mm/slab: add kernel-doc for one function

hoi :)

On Sun, Jan 22, 2006 at 10:19:26PM +0100, Sam Ravnborg wrote:
> That is the responsibility of the subsystem maintainer - as you have
> become now.
> At least in the normal case Andrew suck in the git trees and leave it to
> the git tree owners to push to Linus.

well, I tried both pushing to Linus and to Andrew, and the route via
Andrew worked better up to now ;-)

But I'd be happy to get my GIT tree accepted by Linus.
I'll just try again from time to time.

--
Martin Waitz


Attachments:
(No filename) (488.00 B)
signature.asc (189.00 B)
Digital signature
Download all attachments