2006-01-29 15:48:53

by OGAWA Hirofumi

[permalink] [raw]
Subject: [PATCH 2/3] Trivial optimization of ll_rw_block()



The ll_rw_block() needs to get ref-count only if it submits a buffer().
This patch avoids the needless get/put of ref-count.

Signed-off-by: OGAWA Hirofumi <[email protected]>
---

fs/buffer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff -puN fs/buffer.c~ll_rw_block-optimize fs/buffer.c
--- linux-2.6/fs/buffer.c~ll_rw_block-optimize 2006-01-12 21:53:00.000000000 +0900
+++ linux-2.6-hirofumi/fs/buffer.c 2006-01-12 21:53:00.000000000 +0900
@@ -2866,22 +2866,22 @@ void ll_rw_block(int rw, int nr, struct
else if (test_set_buffer_locked(bh))
continue;

- get_bh(bh);
if (rw == WRITE || rw == SWRITE) {
if (test_clear_buffer_dirty(bh)) {
bh->b_end_io = end_buffer_write_sync;
+ get_bh(bh);
submit_bh(WRITE, bh);
continue;
}
} else {
if (!buffer_uptodate(bh)) {
bh->b_end_io = end_buffer_read_sync;
+ get_bh(bh);
submit_bh(rw, bh);
continue;
}
}
unlock_buffer(bh);
- put_bh(bh);
}
}

_