2006-02-11 05:45:14

by Randy Dunlap

Subject: [PATCH] slab: fix kernel-doc warnings

From: Randy Dunlap <[email protected]>

Fix kernel-doc warnings in mm/slab.c.

Signed-off-by: Randy Dunlap <[email protected]>
---
mm/slab.c | 13 +++++++++++--
1 files changed, 11 insertions(+), 2 deletions(-)

--- linux-2616-rc2g9.orig/mm/slab.c
+++ linux-2616-rc2g9/mm/slab.c
@@ -1526,8 +1526,12 @@ static void check_poison_obj(struct kmem

#if DEBUG
/**
- * slab_destroy_objs - call the registered destructor for each object in
- * a slab that is to be destroyed.
+ * slab_destroy_objs - destroy a slab and its objects
+ * @cachep: cache pointer being destroyed
+ * @slabp: slab pointer being destroyed
+ *
+ * Call the registered destructor for each object in a slab that is being
+ * destroyed.
*/
static void slab_destroy_objs(struct kmem_cache *cachep, struct slab *slabp)
{
@@ -1574,6 +1578,10 @@ static void slab_destroy_objs(struct kme
#endif

/**
+ * slab_destroy - destroy and release all objects in a slab
+ * @cachep: cache pointer being destroyed
+ * @slabp: slab pointer being destroyed
+ *
* Destroy all the objs in a slab, and release the mem back to the system.
* Before calling the slab must have been unlinked from the cache.
* The cache-lock is not held/needed.
@@ -3085,6 +3093,7 @@ EXPORT_SYMBOL(kmalloc_node);
* kmalloc - allocate memory
* @size: how many bytes of memory are required.
* @flags: the type of memory to allocate.
+ * @caller: function caller for debug tracking of the caller
*
* kmalloc is the normal method of allocating memory
* in the kernel.


---

2006-02-11 11:34:55

by Pekka Enberg

Subject: Re: [PATCH] slab: fix kernel-doc warnings

On Fri, 2006-02-10 at 21:45 -0800, Randy.Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Fix kernel-doc warnings in mm/slab.c.
>
> Signed-off-by: Randy Dunlap <[email protected]>

Looks good to me. Thanks.

Pekka