2006-02-16 04:23:00

by Mark Tomich

Subject: patch to speedstep-centrino.c

I guess I goofed by submitting this in HTML previously...sorry...

Below is a patch to the speedstep-centrino.c file. It's needed to fix a missing symbol error (online_cpu_map) in the latest mm patch of the kernel.

--- linux-2.6.16-rc3-mm1/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c 2006-02-15 22:31:54.561277488 -0500
+++ linux-2.6.16-rc3-mm1-patched/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c 2006-02-15 22:05:15.964091566 -0500
@@ -654,8 +654,10 @@ static int centrino_target (struct cpufr
return -EINVAL;
}

+#ifdef CONFIG_SMP
/* cpufreq holds the hotplug lock, so we are safe from here on */
cpus_and(online_policy_cpus, cpu_online_map, policy->cpus);
+#endif

saved_mask = current->cpus_allowed;
first_cpu = 1;

2006-02-16 04:36:56

by Dave Jones

Subject: Re: patch to speedstep-centrino.c

On Wed, Feb 15, 2006 at 11:22:58PM -0500, [email protected] wrote:
> I guess I goofed by submitting this in HTML previously...sorry...
>
> Below is a patch to the speedstep-centrino.c file. It's needed to fix a missing symbol error (online_cpu_map) in the latest mm patch of the kernel.
>
> --- linux-2.6.16-rc3-mm1/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c 2006-02-15 22:31:54.561277488 -0500
> +++ linux-2.6.16-rc3-mm1-patched/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c 2006-02-15 22:05:15.964091566 -0500
> @@ -654,8 +654,10 @@ static int centrino_target (struct cpufr
> return -EINVAL;
> }
>
> +#ifdef CONFIG_SMP
> /* cpufreq holds the hotplug lock, so we are safe from here on */
> cpus_and(online_policy_cpus, cpu_online_map, policy->cpus);
> +#endif
>
> saved_mask = current->cpus_allowed;
> first_cpu = 1;

As this is an -mm specific problem right now, I've not merged
this into the cpufreq git tree.

I expect Andrew has it queued up for -mm2, and will submit it the same
time as the patches that cause the breakage.

Dave