2006-02-17 13:22:48

by Adrian Bunk

[permalink] [raw]
Subject: [2.6 patch] show "SN Devices" menu only if CONFIG_SGI_SN

On architectures like i386, the "Multimedia Capabilities Port drivers"
menu is visible, but it can't be visited since it contains nothing
usable for CONFIG_SGI_SN=n.


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.16-rc3-mm1-full/drivers/sn/Kconfig.old 2006-02-17 14:07:11.000000000 +0100
+++ linux-2.6.16-rc3-mm1-full/drivers/sn/Kconfig 2006-02-17 14:07:37.000000000 +0100
@@ -3,6 +3,7 @@
#

menu "SN Devices"
+ depends on SGI_SN

config SGI_IOC4
tristate "SGI IOC4 Base IO support"


2006-02-17 15:25:41

by Jes Sorensen

[permalink] [raw]
Subject: Re: [2.6 patch] show "SN Devices" menu only if CONFIG_SGI_SN

>>>>> "Adrian" == Adrian Bunk <[email protected]> writes:

Adrian> On architectures like i386, the "Multimedia Capabilities Port
Adrian> drivers" menu is visible, but it can't be visited since it
Adrian> contains nothing usable for CONFIG_SGI_SN=n.

Thats only a third of the patch, if you want to do that, you should
remove the redundant SGI_SN checks below.

Like this.

Jes

drivers/sn/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6/drivers/sn/Kconfig
===================================================================
--- linux-2.6.orig/drivers/sn/Kconfig
+++ linux-2.6/drivers/sn/Kconfig
@@ -3,10 +3,11 @@
#

menu "SN Devices"
+ depends on SGI_SN

config SGI_IOC4
tristate "SGI IOC4 Base IO support"
- depends on (IA64_GENERIC || IA64_SGI_SN2) && MMTIMER
+ depends on MMTIMER
default m
---help---
This option enables basic support for the SGI IOC4-based Base IO
@@ -19,7 +20,6 @@

config SGI_IOC3
tristate "SGI IOC3 Base IO support"
- depends on (IA64_GENERIC || IA64_SGI_SN2)
default m
---help---
This option enables basic support for the SGI IOC3-based Base IO

2006-02-17 16:33:24

by Adrian Bunk

[permalink] [raw]
Subject: Re: [2.6 patch] show "SN Devices" menu only if CONFIG_SGI_SN

On Fri, Feb 17, 2006 at 10:25:39AM -0500, Jes Sorensen wrote:
> >>>>> "Adrian" == Adrian Bunk <[email protected]> writes:
>
> Adrian> On architectures like i386, the "Multimedia Capabilities Port
> Adrian> drivers" menu is visible, but it can't be visited since it
> Adrian> contains nothing usable for CONFIG_SGI_SN=n.
>
> Thats only a third of the patch, if you want to do that, you should
> remove the redundant SGI_SN checks below.
>
> Like this.

Looks good.

> Jes
>...

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed