On 17/02/06 13:09 +0000, Nick Warne wrote:
> '
> > if (kind <= 0) { /* identification failed */
> > @@ -296,10 +318,15 @@ static int lm83_detect(struct i2c_adapte
> > if (kind == lm83) {
> > name = "lm83";
> > }
> > + else if (kind = lm82) {
> > + name = "lm82";
> > + }
>
> Is that a '=' typo in the 'else if' there?
Yep - thats what that would be. That must be my typo of the week, since
I just had it in another driver I'm writing. I'll post a fixup here
very shortly with all the comments.
Jordan
--
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<http://www.amd.com/embeddedprocessors>
Hi Jordan,
> On 17/02/06 13:09 +0000, Nick Warne wrote:
> > > + else if (kind = lm82) {
> > > + name = "lm82";
> > > + }
> >
> > Is that a '=' typo in the 'else if' there?
>
> Yep - thats what that would be. That must be my typo of the week, since
> I just had it in another driver I'm writing.
Given that gcc clearly warns on this kind of typo, how could it go
unnoticed?
--
Jean Delvare
Hi Jordan,
> Yep - thats what that would be. That must be my typo of the week, since
> I just had it in another driver I'm writing. I'll post a fixup here
> very shortly with all the comments.
Where's that update? I'd like to merge it upstream.
Remember that a patch for user-space support would be welcome too.
Thanks,
--
Jean Delvare