2006-03-11 15:10:39

by Adrian Bunk

Subject: [2.6 patch] drivers/input/gameport/gameport.c: fix a memory leak

This patch fixes a memory leak found by the Coverity checker.


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.16-rc5-mm3-full/drivers/input/gameport/gameport.c.old 2006-03-11 14:28:35.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/drivers/input/gameport/gameport.c 2006-03-11 14:28:53.000000000 +0100
@@ -266,6 +266,7 @@ static void gameport_queue_event(void *o
if ((event = kmalloc(sizeof(struct gameport_event), GFP_ATOMIC))) {
if (!try_module_get(owner)) {
printk(KERN_WARNING "gameport: Can't get module reference, dropping event %d\n", event_type);
+ kfree(event);
goto out;
}

2006-03-14 05:18:16

by Dmitry Torokhov

Subject: Re: [2.6 patch] drivers/input/gameport/gameport.c: fix a memory leak

On Saturday 11 March 2006 10:10, Adrian Bunk wrote:
> This patch fixes a memory leak found by the Coverity checker.
>

Both patches applied, thank you Adrian.

Because the leak is very hard to trigger it will not be merged until
2.6.17 opens up.

--
Dmitry